Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-04-05 Thread YH Huang
On Sat, 2016-04-02 at 05:46 +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Mar 31, 2016 at 10:42:31AM +0800, YH Huang wrote: > > On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote: > > > Hi, > > > > > > On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote: > > > > If I revise the d

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-04-01 Thread Sebastian Reichel
Hi, On Thu, Mar 31, 2016 at 10:42:31AM +0800, YH Huang wrote: > On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote: > > Hi, > > > > On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote: > > > If I revise the description in this way(using your clear explanation): > > >

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread YH Huang
On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote: > > If I revise the description in this way(using your clear explanation): > > > > The battery ca

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread Sebastian Reichel
Hi, On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote: > If I revise the description in this way(using your clear explanation): > > The battery capacity changing course is like this: > > full: BATTERY_FULLY_CHARGED =>

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread Rhyland Klein
On 3/30/2016 4:58 AM, YH Huang wrote: > On Tue, 2016-03-29 at 11:05 -0400, Rhyland Klein wrote: >> On 3/28/2016 9:52 PM, YH Huang wrote: >>> On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > +Rhyland Klein who original wrote this code... >>

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-30 Thread YH Huang
On Tue, 2016-03-29 at 11:05 -0400, Rhyland Klein wrote: > On 3/28/2016 9:52 PM, YH Huang wrote: > > On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: > >> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > >>> +Rhyland Klein who original wrote this code... > >>> > >>> On Mon, Mar 28, 2016 at 10:32 A

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-29 Thread Rhyland Klein
On 3/28/2016 9:52 PM, YH Huang wrote: > On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: >> On 3/28/2016 6:05 AM, Daniel Kurtz wrote: >>> +Rhyland Klein who original wrote this code... >>> >>> On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: On Fri, 2016-03-25 at 11:06 +0800, Dan

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread YH Huang
On Mon, 2016-03-28 at 11:57 -0400, Rhyland Klein wrote: > On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > > +Rhyland Klein who original wrote this code... > > > > On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: > >> > >> On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: > >>> On Thu, Mar 24, 2

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread Rhyland Klein
On 3/28/2016 6:05 AM, Daniel Kurtz wrote: > +Rhyland Klein who original wrote this code... > > On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: >> >> On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: >>> On Thu, Mar 24, 2016 at 2:43 PM, YH Huang wrote: Hi Daniel, On Thu

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-28 Thread Daniel Kurtz
+Rhyland Klein who original wrote this code... On Mon, Mar 28, 2016 at 10:32 AM, YH Huang wrote: > > On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: > > On Thu, Mar 24, 2016 at 2:43 PM, YH Huang wrote: > > > > > > Hi Daniel, > > > > > > On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrot

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-27 Thread YH Huang
On Fri, 2016-03-25 at 11:06 +0800, Daniel Kurtz wrote: > On Thu, Mar 24, 2016 at 2:43 PM, YH Huang wrote: > > > > Hi Daniel, > > > > On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > > > Hi YH, > > > > > > On Wed, Mar 23, 2016 at 5:53 PM, YH Huang wrote: > > > > When the battery is dry and

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-24 Thread Daniel Kurtz
On Thu, Mar 24, 2016 at 2:43 PM, YH Huang wrote: > > Hi Daniel, > > On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > > Hi YH, > > > > On Wed, Mar 23, 2016 at 5:53 PM, YH Huang wrote: > > > When the battery is dry and BATTERY_FULL_DISCHARGED is set, > > > we should check BATTERY_DISCHARGIN

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-23 Thread YH Huang
Hi Daniel, On Thu, 2016-03-24 at 12:01 +0800, Daniel Kurtz wrote: > Hi YH, > > On Wed, Mar 23, 2016 at 5:53 PM, YH Huang wrote: > > When the battery is dry and BATTERY_FULL_DISCHARGED is set, > > we should check BATTERY_DISCHARGING to decide the power status. > > If BATTERY_DISCHARGING is set, t

Re: [PATCH] sbs-battery: fix power status when battery is dry

2016-03-23 Thread Daniel Kurtz
Hi YH, On Wed, Mar 23, 2016 at 5:53 PM, YH Huang wrote: > When the battery is dry and BATTERY_FULL_DISCHARGED is set, > we should check BATTERY_DISCHARGING to decide the power status. > If BATTERY_DISCHARGING is set, the power status is not charging. > Or the power status should be charging. > >

[PATCH] sbs-battery: fix power status when battery is dry

2016-03-23 Thread YH Huang
When the battery is dry and BATTERY_FULL_DISCHARGED is set, we should check BATTERY_DISCHARGING to decide the power status. If BATTERY_DISCHARGING is set, the power status is not charging. Or the power status should be charging. Signed-off-by: YH Huang --- drivers/power/sbs-battery.c | 22