Re: [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED

2019-06-19 Thread Juri Lelli
Hi, On 19/06/19 11:29, Michal Koutný wrote: > On Wed, Jun 05, 2019 at 04:20:03PM +0200, Michal Koutný > wrote: > > I considered relaxing the check to non-root cgroups only, however, as > > your example shows, it doesn't prevent reaching the avoided state by > > other paths. I'm not that familiar

Re: [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED

2019-06-19 Thread Michal Koutný
On Wed, Jun 05, 2019 at 04:20:03PM +0200, Michal Koutný wrote: > I considered relaxing the check to non-root cgroups only, however, as > your example shows, it doesn't prevent reaching the avoided state by > other paths. I'm not that familiar with RT sched to tell whether > RT-priority tasks in d

Re: [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED

2019-06-05 Thread Michal Koutný
On Wed, Jun 05, 2019 at 01:49:35PM +0200, Juri Lelli wrote: > Existing code comes with a comment saying the "we don't support RT-tasks > being in separate groups". I'm also inclined to this check not being completely correct. This guard also prevents enabling cpu controller on unified hierarchy

Re: [PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED

2019-06-05 Thread Tejun Heo
Hello, On Wed, Jun 05, 2019 at 01:49:35PM +0200, Juri Lelli wrote: > On !CONFIG_RT_GROUP_SCHED configurations it is currently not possible to > move RT tasks between cgroups to which cpu controller has been attached; > but it is oddly possible to first move tasks around and then make them > RT (se

[PATCH] sched/core: Fix cpu controller for !RT_GROUP_SCHED

2019-06-05 Thread Juri Lelli
On !CONFIG_RT_GROUP_SCHED configurations it is currently not possible to move RT tasks between cgroups to which cpu controller has been attached; but it is oddly possible to first move tasks around and then make them RT (setschedule to FIFO/RR). E.g.: # mkdir /sys/fs/cgroup/cpu,cpuacct/group1