Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-19 Thread Paolo Bonzini
On 19/03/21 09:07, Emanuele Giuseppe Esposito wrote: I'm not sure why the original kvm selftests authors decided to do this internal stuff, but we should either kill that or avoid doing stuff like this. I need this include because of the KVM_DEV_PATH macro, to get the kvm_fd. No other reason f

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-19 Thread Emanuele Giuseppe Esposito
Hi Andrew, Thank you for the feedback (also in v1). On 18/03/2021 18:03, Andrew Jones wrote: On Thu, Mar 18, 2021 at 03:56:29PM +0100, Emanuele Giuseppe Esposito wrote: Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito ---

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Sean Christopherson
On Thu, Mar 18, 2021, Paolo Bonzini wrote: > On 18/03/21 18:03, Andrew Jones wrote: > > > > > > TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test > > > +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features > > > > Maybe we should give up trying to keep an alphabetic order. > > FWIW I had fix

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Andrew Jones
On Thu, Mar 18, 2021 at 06:33:35PM +0100, Paolo Bonzini wrote: > On 18/03/21 18:03, Andrew Jones wrote: > > > > > > TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test > > > +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features > > > > Maybe we should give up trying to keep an alphabetic order.

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Paolo Bonzini
On 18/03/21 18:03, Andrew Jones wrote: TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features Maybe we should give up trying to keep an alphabetic order. FWIW I had fixed that but yeah maybe we should just give up. +int main(int argc, ch

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Andrew Jones
On Thu, Mar 18, 2021 at 03:56:29PM +0100, Emanuele Giuseppe Esposito wrote: > Test the KVM_GET_MSR_FEATURE_INDEX_LIST > and KVM_GET_MSR_INDEX_LIST ioctls. > > Signed-off-by: Emanuele Giuseppe Esposito > --- > tools/testing/selftests/kvm/.gitignore| 1 + > tools/testing/selftests/kvm/Ma

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Paolo Bonzini
On 18/03/21 15:56, Emanuele Giuseppe Esposito wrote: Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito Looks good, thanks. I queued it with a little extra code to verify KVM_GET_MSR_INDEX_LIST in the case that does not retur

[PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Emanuele Giuseppe Esposito
Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito --- tools/testing/selftests/kvm/.gitignore| 1 + tools/testing/selftests/kvm/Makefile | 1 + .../kvm/x86_64/get_msr_index_features.c | 124 +