Re: [PATCH] serial/8250: remove comment about schedule_timeout

2017-01-05 Thread Theodore Ts'o
On Thu, Jan 05, 2017 at 03:17:45PM -0200, Thadeu Lima de Souza Cascardo wrote: > Okay. At first, I wanted to simply use msleep there, then realized there > was the spinlock. I thought I got a good writeup of the history that was > not in git yet, maybe we should just add a better comment and more >

Re: [PATCH] serial/8250: remove comment about schedule_timeout

2017-01-05 Thread One Thousand Gnomes
On Thu, 5 Jan 2017 13:48:40 -0200 Thadeu Lima de Souza Cascardo wrote: > Ted T'so has added the function size_fifo in 1999 for the 2.3 series > [1], a long time ago. > > During the 2.5 cycle, Russell King has restructured the serial drivers > and, in that process, has suggested using schedule_t

Re: [PATCH] serial/8250: remove comment about schedule_timeout

2017-01-05 Thread Thadeu Lima de Souza Cascardo
On Thu, Jan 05, 2017 at 04:40:16PM +, One Thousand Gnomes wrote: > On Thu, 5 Jan 2017 13:48:40 -0200 > Thadeu Lima de Souza Cascardo wrote: > > > Ted T'so has added the function size_fifo in 1999 for the 2.3 series > > [1], a long time ago. > > > > During the 2.5 cycle, Russell King has res

[PATCH] serial/8250: remove comment about schedule_timeout

2017-01-05 Thread Thadeu Lima de Souza Cascardo
Ted T'so has added the function size_fifo in 1999 for the 2.3 series [1], a long time ago. During the 2.5 cycle, Russell King has restructured the serial drivers and, in that process, has suggested using schedule_timeout instead of mdelay in size_fifo. [2] It was only at 2.6.7 that Greg Kroah-Har