Re: [PATCH] sparse: use identifiers to define address spaces

On Fri, Jun 19, 2020 at 10:07:34AM +0200, Geert Uytterhoeven wrote: > > Indeed. It looks like this whole list is completely unsorted, and was created > by appending new definitions at the bottom. > So perhaps all the address_space ones should be grouped together? Hi Geert & Miguel, Yes, some

Re: [PATCH] sparse: use identifiers to define address spaces

On Fri, Jun 19, 2020 at 10:07 AM Geert Uytterhoeven wrote: > > Indeed. It looks like this whole list is completely unsorted, and was created > by appending new definitions at the bottom. The "historical ordering" :) +1 for sorting, whatever the ordering (and perhaps adding a comment saying

Re: [PATCH] sparse: use identifiers to define address spaces

Hi Luc, On Thu, Jun 18, 2020 at 7:05 AM Luc Van Oostenryck wrote: > On Thu, Jun 18, 2020 at 03:22:15AM +0200, Miguel Ojeda wrote: > > On Thu, Jun 18, 2020 at 12:02 AM Luc Van Oostenryck > > wrote: > > > > > > diff --git a/include/linux/compiler_types.h > > > b/include/linux/compiler_types.h >

Re: [PATCH] sparse: use identifiers to define address spaces

On Thu, Jun 18, 2020 at 09:59:05AM -0700, Linus Torvalds wrote: > > The new warnings don't seem to be due to the kernel test robot having > an old version of sparse, but just because the error strings changed, > and presumably the kernel test robot has some "ignore old sparse > warnings" logic. >

Re: [PATCH] sparse: use identifiers to define address spaces

On Thu, Jun 18, 2020 at 3:06 AM kernel test robot wrote: > > I love your patch! Perhaps something to improve: The new warnings don't seem to be due to the kernel test robot having an old version of sparse, but just because the error strings changed, and presumably the kernel test robot has some

Re: [PATCH] sparse: use identifiers to define address spaces

Hi Luc, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

Re: [PATCH] sparse: use identifiers to define address spaces

Hi Luc, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

Re: [PATCH] sparse: use identifiers to define address spaces

Hi Luc, I love your patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented

Re: [PATCH] sparse: use identifiers to define address spaces

On Thu, Jun 18, 2020 at 03:22:15AM +0200, Miguel Ojeda wrote: > Hi Luc, Hi Miguel, > On Thu, Jun 18, 2020 at 12:02 AM Luc Van Oostenryck > wrote: > > > > diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h > > index 21aed0981edf..e368384445b6 100644 > > ---

Re: [PATCH] sparse: use identifiers to define address spaces

Hi Luc, On Thu, Jun 18, 2020 at 12:02 AM Luc Van Oostenryck wrote: > > diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h > index 21aed0981edf..e368384445b6 100644 > --- a/include/linux/compiler_types.h > +++ b/include/linux/compiler_types.h > @@ -5,20 +5,20 @@ >

[PATCH] sparse: use identifiers to define address spaces

Currently, address spaces in warnings are displayed as '' with 'X' replaced with the address space's number. But since v0.6.0-rc1 (late December 2018), Sparse allows to define the address spaces using an identifier instead of a number. This identifier is then directly used in the warnings. So,