Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-17 Thread Rickard Strandqvist
Hi Ok, do a patch to remove it now. Kind regards Rickard Strandqvist 2014-12-16 1:04 GMT+01:00 Larry Finger : > On 12/15/2014 05:01 PM, Rickard Strandqvist wrote: >> >> Hi >> >> No the rtw_hw_resume23a() is not used anywhere. >> I also do a check of all functions that are not used, but not in

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-17 Thread Rickard Strandqvist
Hi Ok, do a patch to remove it now. Kind regards Rickard Strandqvist 2014-12-16 1:04 GMT+01:00 Larry Finger larry.fin...@lwfinger.net: On 12/15/2014 05:01 PM, Rickard Strandqvist wrote: Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Larry Finger
On 12/15/2014 05:01 PM, Rickard Strandqvist wrote: Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not used, but not in the drivers/staging, I suspected that these might be under development and used in the future. What do you want to do, who

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Rickard Strandqvist
Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not used, but not in the drivers/staging, I suspected that these might be under development and used in the future. What do you want to do, who decides? Kind regards Rickard Strandqvist 2014-12-15

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Jes Sorensen
Dan Carpenter writes: > On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: >> There is otherwise a risk of a possible null pointer dereference. >> >> Was largely found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist >> --- >>

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Dan Carpenter
On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- >

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Dan Carpenter
On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Jes Sorensen
Dan Carpenter dan.carpen...@oracle.com writes: On Sun, Dec 14, 2014 at 11:39:14PM +0100, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Rickard Strandqvist
Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not used, but not in the drivers/staging, I suspected that these might be under development and used in the future. What do you want to do, who decides? Kind regards Rickard Strandqvist 2014-12-15

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-15 Thread Larry Finger
On 12/15/2014 05:01 PM, Rickard Strandqvist wrote: Hi No the rtw_hw_resume23a() is not used anywhere. I also do a check of all functions that are not used, but not in the drivers/staging, I suspected that these might be under development and used in the future. What do you want to do, who

[PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-14 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/os_dep/usb_intf.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] staging: rtl8723au: os_dep: usb_intf.c: Fix for possible null pointer dereference

2014-12-14 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/rtl8723au/os_dep/usb_intf.c |3 ++- 1 file changed, 2