Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-12-04 Thread Daniel Lezcano
On 05/12/2017 02:52, Eduardo Valentin wrote: > Hello, > > Catching up on old patches. > On Fri, Jul 07, 2017 at 05:03:52PM +0200, Daniel Lezcano wrote: >> The sensor id is unknown at init time and we use all id in the authorized >> MAX_SENSORS interval to register the sensor. On this SoC there is

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-12-04 Thread Daniel Lezcano
On 05/12/2017 02:52, Eduardo Valentin wrote: > Hello, > > Catching up on old patches. > On Fri, Jul 07, 2017 at 05:03:52PM +0200, Daniel Lezcano wrote: >> The sensor id is unknown at init time and we use all id in the authorized >> MAX_SENSORS interval to register the sensor. On this SoC there is

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-12-04 Thread Eduardo Valentin
Hello, Catching up on old patches. On Fri, Jul 07, 2017 at 05:03:52PM +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-12-04 Thread Eduardo Valentin
Hello, Catching up on old patches. On Fri, Jul 07, 2017 at 05:03:52PM +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-23 Thread Leo Yan
On Tue, Aug 22, 2017 at 10:25:07AM +0200, Daniel Lezcano wrote: > On 22/08/2017 10:04, Leo Yan wrote: > > Hi Daniel, > > > > On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: > > > > [...] > > > >> Hi Leo, > >> > >> a cleanest solution would be either: > >> > >> - add the 3

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-23 Thread Leo Yan
On Tue, Aug 22, 2017 at 10:25:07AM +0200, Daniel Lezcano wrote: > On 22/08/2017 10:04, Leo Yan wrote: > > Hi Daniel, > > > > On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: > > > > [...] > > > >> Hi Leo, > >> > >> a cleanest solution would be either: > >> > >> - add the 3

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-22 Thread Daniel Lezcano
On 22/08/2017 10:04, Leo Yan wrote: > Hi Daniel, > > On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: > > [...] > >> Hi Leo, >> >> a cleanest solution would be either: >> >> - add the 3 missing thermal sensors in the DT and default to the id 2 > > Yeah, so do you think below

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-22 Thread Daniel Lezcano
On 22/08/2017 10:04, Leo Yan wrote: > Hi Daniel, > > On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: > > [...] > >> Hi Leo, >> >> a cleanest solution would be either: >> >> - add the 3 missing thermal sensors in the DT and default to the id 2 > > Yeah, so do you think below

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-22 Thread Leo Yan
Hi Daniel, On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: [...] > Hi Leo, > > a cleanest solution would be either: > > - add the 3 missing thermal sensors in the DT and default to the id 2 Yeah, so do you think below change works for you? ---8<--- ARM64: dts:

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-22 Thread Leo Yan
Hi Daniel, On Mon, Aug 21, 2017 at 12:06:17PM +0200, Daniel Lezcano wrote: [...] > Hi Leo, > > a cleanest solution would be either: > > - add the 3 missing thermal sensors in the DT and default to the id 2 Yeah, so do you think below change works for you? ---8<--- ARM64: dts:

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-21 Thread Daniel Lezcano
On 08/08/2017 15:29, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > platform_device *pdev) > ret = hisi_thermal_register_sensor(pdev, data, >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-21 Thread Daniel Lezcano
On 08/08/2017 15:29, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > platform_device *pdev) > ret = hisi_thermal_register_sensor(pdev, data, >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 21:29 +0800, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > > > > > > > > > > > > > > > > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > > > > > platform_device *pdev) > > > > >   ret =

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 21:29 +0800, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > > > > > > > > > > > > > > > > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > > > > > platform_device *pdev) > > > > >   ret =

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Leo Yan
On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: [...] > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > > > > platform_device *pdev) > > > >   ret = hisi_thermal_register_sensor(pdev, data, > > > >       > >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Leo Yan
On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: [...] > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_probe(struct > > > > platform_device *pdev) > > > >   ret = hisi_thermal_register_sensor(pdev, data, > > > >       > >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:15 +0200, Daniel Lezcano wrote: > On 08/08/2017 09:55, Zhang Rui wrote: > > > > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > > > > > > The sensor id is unknown at init time and we use all id in the > > > authorized > > > MAX_SENSORS interval to register the

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:15 +0200, Daniel Lezcano wrote: > On 08/08/2017 09:55, Zhang Rui wrote: > > > > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > > > > > > The sensor id is unknown at init time and we use all id in the > > > authorized > > > MAX_SENSORS interval to register the

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Daniel Lezcano
On 08/08/2017 09:55, Zhang Rui wrote: > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: >> The sensor id is unknown at init time and we use all id in the >> authorized >> MAX_SENSORS interval to register the sensor. On this SoC there is one >> thermal-zone with one sensor on it. No need

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Daniel Lezcano
On 08/08/2017 09:55, Zhang Rui wrote: > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: >> The sensor id is unknown at init time and we use all id in the >> authorized >> MAX_SENSORS interval to register the sensor. On this SoC there is one >> thermal-zone with one sensor on it. No need

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the > authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to spit on the console > everytime we >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the > authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to spit on the console > everytime we >

[PATCH] thermal/drivers/hisi: Remove confusing error message

2017-07-07 Thread Daniel Lezcano
The sensor id is unknown at init time and we use all id in the authorized MAX_SENSORS interval to register the sensor. On this SoC there is one thermal-zone with one sensor on it. No need to spit on the console everytime we failed to register thermal sensors, information which is deliberaly known

[PATCH] thermal/drivers/hisi: Remove confusing error message

2017-07-07 Thread Daniel Lezcano
The sensor id is unknown at init time and we use all id in the authorized MAX_SENSORS interval to register the sensor. On this SoC there is one thermal-zone with one sensor on it. No need to spit on the console everytime we failed to register thermal sensors, information which is deliberaly known