[PATCH] thermal: armada: read stable temp on Armada XP

2015-02-10 Thread Tyler Hall
The current register being used to read the temperature returns a noisy value that is prone to variance and occasional outliers. The value in the thermal manager control and status register appears to have the same scale but much less variability. Add a "marvell,armadaxp-filtered-thermal" config w

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Gregory CLEMENT
Hi Tyler, Eduardo, On 24/02/2015 20:56, Tyler Hall wrote: > Eduardo, > > On Tue, Feb 24, 2015 at 1:36 PM, Eduardo Valentin wrote: >> The fix seams reasonable. Although, it remains the question what is >> applicability to other Armada chips? Besides, shouldn't we simply use it >> by default? Also

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Gregory CLEMENT
Hi Tyler, On 10/02/2015 23:50, Tyler Hall wrote: > The current register being used to read the temperature returns a noisy value > that is prone to variance and occasional outliers. The value in the thermal > manager control and status register appears to have the same scale but much > less variab

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Ezequiel Garcia
On 02/25/2015 02:04 PM, Gregory CLEMENT wrote: >> >> My conclusions about these registers are based on experimental data. The >> documentation is very sparse, but the Thermal Manager Control and Status >> Register looks like the preferred register given the way it is laid out in >> the >> public s

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Gregory CLEMENT
Hi Ezequiel, On 25/02/2015 19:17, Ezequiel Garcia wrote: > On 02/25/2015 02:04 PM, Gregory CLEMENT wrote: >>> >>> My conclusions about these registers are based on experimental data. The >>> documentation is very sparse, but the Thermal Manager Control and Status >>> Register looks like the prefer

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Eduardo Valentin
On Wed, Feb 25, 2015 at 05:10:14PM +0100, Gregory CLEMENT wrote: > Hi Tyler, Eduardo, > > On 24/02/2015 20:56, Tyler Hall wrote: > > Eduardo, > > > > On Tue, Feb 24, 2015 at 1:36 PM, Eduardo Valentin > > wrote: > >> The fix seams reasonable. Although, it remains the question what is > >> applic

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Tyler Hall
Hi Gregory, Eduardo, On Wed, Feb 25, 2015 at 05:10:14PM +0100, Gregory CLEMENT wrote: > By using it by default do you mean removing marvell,armadaxp-thermal > and adding armadaxp-filtered-thermal instead ? Yes, replacing it in device tree. For me, /sys/class/thermal/thermal_zone0/temp returns the

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-25 Thread Tyler Hall
Gregory, I instantiated both configurations and verified I get essentially the same temperature from both, with the original register having a slightly larger spread. I didn't reproduce any outliers in this run, but I'll keep it running for a while to see if any occur. I'm running this to gather

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-24 Thread Eduardo Valentin
Tyler, On Tue, Feb 10, 2015 at 05:50:15PM -0500, Tyler Hall wrote: > The current register being used to read the temperature returns a noisy value > that is prone to variance and occasional outliers. The value in the thermal > manager control and status register appears to have the same scale but

Re: [PATCH] thermal: armada: read stable temp on Armada XP

2015-02-24 Thread Tyler Hall
Eduardo, On Tue, Feb 24, 2015 at 1:36 PM, Eduardo Valentin wrote: > The fix seams reasonable. Although, it remains the question what is > applicability to other Armada chips? Besides, shouldn't we simply use it > by default? Also, do you plan to send updates in the DTS files? As far as I can tel