Re: [PATCH] tools lib fd array: Do not set fd as non blocking evlist

2014-09-11 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 11, 2014 at 12:27:26PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Sep 11, 2014 at 05:09:43PM +0200, Jiri Olsa escreveu: > > > + fcntl(fd, F_SETFL, O_NONBLOCK); > > > > also I spot this one and couldn't think of reason for it, attached > > patch makes no behaviour difference fo

Re: [PATCH] tools lib fd array: Do not set fd as non blocking evlist

2014-09-11 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 11, 2014 at 05:09:43PM +0200, Jiri Olsa escreveu: > On Wed, Sep 10, 2014 at 11:08:46AM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > +} > > + > > +void fdarray__exit(struct fdarray *fda) > > +{ > > + free(fda->entries); > > + fdarray__init(fda, 0); > > +} > > + > > +void f

[PATCH] tools lib fd array: Do not set fd as non blocking evlist

2014-09-11 Thread Jiri Olsa
On Wed, Sep 10, 2014 at 11:08:46AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > +} > + > +void fdarray__exit(struct fdarray *fda) > +{ > + free(fda->entries); > + fdarray__init(fda, 0); > +} > + > +void fdarray__delete(struct fdarray *fda) > +{ > + fdarray__exit(fda); > + free(fd