Re: [PATCH] vimc: Add colors' order over test image

2020-06-12 Thread kernel test robot
Hi Kaaira, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20200612] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to

Re: [PATCH] vimc: Add colors' order over test image

2020-06-12 Thread kernel test robot
Hi Kaaira, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20200612] [cannot apply to v5.7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also sug

[PATCH] vimc: Add colors' order over test image

2020-06-12 Thread Kaaira Gupta
Currently there is no method to know if the test image generated by vimc is correct (except for comparing it with a known 'correct' image). Add a function which returns the correct order of the colors in test pattern. And hence, add that text over the test image. Add a null check in tpg_gen_text()

Re: [RFC PATCH] vimc: Add colors' order over test image

2020-06-08 Thread Hans Verkuil
On 08/06/2020 14:12, Laurent Pinchart wrote: > Hello, > > On Mon, Jun 08, 2020 at 11:33:21AM +0200, Hans Verkuil wrote: >> On 08/06/2020 09:10, Dafna Hirschfeld wrote: >>> On 07.06.20 15:53, Kaaira Gupta wrote: Currently there is no method to know if the test image generated by vimc is c

Re: [RFC PATCH] vimc: Add colors' order over test image

2020-06-08 Thread Laurent Pinchart
Hello, On Mon, Jun 08, 2020 at 11:33:21AM +0200, Hans Verkuil wrote: > On 08/06/2020 09:10, Dafna Hirschfeld wrote: > > On 07.06.20 15:53, Kaaira Gupta wrote: > >> Currently there is no method to know if the test image generated by vimc > >> is correct (except for comparing it with a known 'correc

Re: [RFC PATCH] vimc: Add colors' order over test image

2020-06-08 Thread Hans Verkuil
On 08/06/2020 09:10, Dafna Hirschfeld wrote: > Hi, > > On 07.06.20 15:53, Kaaira Gupta wrote: >> Currently there is no method to know if the test image generated by vimc >> is correct (except for comparing it with a known 'correct' image). Add >> text over the test image, representing the correct

Re: [RFC PATCH] vimc: Add colors' order over test image

2020-06-08 Thread Dafna Hirschfeld
Hi, On 07.06.20 15:53, Kaaira Gupta wrote: Currently there is no method to know if the test image generated by vimc is correct (except for comparing it with a known 'correct' image). Add text over the test image, representing the correct order of colors. I have sent it as an RFC because we can

[RFC PATCH] vimc: Add colors' order over test image

2020-06-07 Thread Kaaira Gupta
Currently there is no method to know if the test image generated by vimc is correct (except for comparing it with a known 'correct' image). Add text over the test image, representing the correct order of colors. I have sent it as an RFC because we can add the text as an optional control, and maybe