Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Gustavo A. R. Silva
Quoting Guenter Roeck : On Fri, Nov 03, 2017 at 04:04:23PM +0100, Wim Van Sebroeck wrote: Hi Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fal

Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Guenter Roeck
On Fri, Nov 03, 2017 at 09:02:33AM -0700, Joe Perches wrote: > On Fri, 2017-11-03 at 08:54 -0700, Guenter Roeck wrote: > > On Fri, Nov 03, 2017 at 04:04:23PM +0100, Wim Van Sebroeck wrote: > > > Hi Gustavo, > > > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > >

Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Joe Perches
On Fri, 2017-11-03 at 08:54 -0700, Guenter Roeck wrote: > On Fri, Nov 03, 2017 at 04:04:23PM +0100, Wim Van Sebroeck wrote: > > Hi Gustavo, > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > Notice that in this

Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Guenter Roeck
On Fri, Nov 03, 2017 at 04:04:23PM +0100, Wim Van Sebroeck wrote: > Hi Gustavo, > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Notice that in this particular case I replaced "Fall" with a proper > > "fall through" com

Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Gustavo A. R. Silva
Hi Wim, Quoting Wim Van Sebroeck : Hi Gustavo, In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find. Sig

Re: [PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Wim Van Sebroeck
Hi Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "Fall" with a proper > "fall through" comment, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R.

[PATCH] watchdog: pcwd_pci: mark expected switch fall-through

2017-11-03 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "Fall" with a proper "fall through" comment, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva --- drivers/watchdo