Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-07-15 Thread Len Brown
> tools/power/x86/turbostat/Makefile | 2 +- Acked-by: Len Brown One of the reasons I put turbostat in the kernel tree was so that it would be easy to have 1 copy of the truth for MSR definitions. I'm okay with treating it like a kernel file and following any MSR name changes in the ke

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-04 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Jun 04, 2015 at 08:09:12AM +0200, Ingo Molnar wrote: > > Something like: > > > > x86/uapi: Remove from the list of exported UAPI headers > > > > or so would work fine with me. > > I did this - this is maximally descriptive IMO. :-) > > --- > From: Bori

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-04 Thread Borislav Petkov
On Thu, Jun 04, 2015 at 08:09:12AM +0200, Ingo Molnar wrote: > Something like: > > x86/uapi: Remove from the list of exported UAPI headers > > or so would work fine with me. I did this - this is maximally descriptive IMO. :-) --- From: Borislav Petkov Date: Wed, 3 Jun 2015 14:37:05 +020

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread Ingo Molnar
* H. Peter Anvin wrote: > On 06/03/2015 11:21 AM, Borislav Petkov wrote: > > On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote: > >> This header containing all MSRs and respective bit definitions got > >> exported to userspace in conjunction with the big uapi shuffle. > >> > >> But

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread H. Peter Anvin
On 06/03/2015 01:06 PM, Borislav Petkov wrote: > On Wed, Jun 03, 2015 at 11:56:33AM -0700, H. Peter Anvin wrote: >> I really like the patch, but the description is awful. >> >> How about: "x86/uapi: is not a UAPI" > > Sure. Commit text needs improvement too? > The commit text is fine, IMO.

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread Borislav Petkov
On Wed, Jun 03, 2015 at 11:56:33AM -0700, H. Peter Anvin wrote: > I really like the patch, but the description is awful. > > How about: "x86/uapi: is not a UAPI" Sure. Commit text needs improvement too? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubs

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread H. Peter Anvin
On 06/03/2015 11:21 AM, Borislav Petkov wrote: > On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote: >> This header containing all MSRs and respective bit definitions got >> exported to userspace in conjunction with the big uapi shuffle. >> >> But, it doesn't have anything to do in the

Re: [PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread Borislav Petkov
t into uapi/asm/msr.h either. --- From: Borislav Petkov Date: Wed, 3 Jun 2015 14:37:05 +0200 Subject: [PATCH] x86/asm/msr: Retract msr-index.h This header containing all MSRs and respective bit definitions got exported to userspace in conjunction with the big uapi shuffle. But, it doesn't hav

[PATCH] x86/asm/msr: Retract msr-index.h

2015-06-03 Thread Borislav Petkov
From: Borislav Petkov This header containing all MSRs and respective bit definitions got exported to userspace in conjunction with the big uapi shuffle. But, it doesn't have anything to do in the uapi headers because userspace can do its own MSR defines and exporting them from the kernel blocks