Re: [PATCH] x86: Remove excess calculations for heap_end_ptr

2014-12-26 Thread H. Peter Anvin
Yes, the -512 is not related to STACK_SIZE, so this patch is wrong. NAK. On December 26, 2014 9:03:38 AM PST, Alexander Kuleshov wrote: >Yes, you're right, > >At first i thought that it is just typo, and right after that i >thought about this case when somebody will change STACK_SIZE > >2014-12

Re: [PATCH] x86: Remove excess calculations for heap_end_ptr

2014-12-26 Thread Alexander Kuleshov
Yes, you're right, At first i thought that it is just typo, and right after that i thought about this case when somebody will change STACK_SIZE 2014-12-26 20:35 GMT+06:00 Jeremiah Mahler : > Alexander, > > On Fri, Dec 26, 2014 at 06:22:42PM +0600, Alexander Kuleshov wrote: >> heap_end_ptr default

Re: [PATCH] x86: Remove excess calculations for heap_end_ptr

2014-12-26 Thread Jeremiah Mahler
Alexander, On Fri, Dec 26, 2014 at 06:22:42PM +0600, Alexander Kuleshov wrote: > heap_end_ptr default value defined as _end+STACK_SZE-512, but STACK_SIZE > STACK_SIZE is already 512. > > Signed-off-by: Alexander Kuleshov > --- > arch/x86/boot/header

[PATCH] x86: Remove excess calculations for heap_end_ptr

2014-12-26 Thread Alexander Kuleshov
heap_end_ptr default value defined as _end+STACK_SZE-512, but STACK_SIZE is already 512. Signed-off-by: Alexander Kuleshov --- arch/x86/boot/header.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S index 16ef025..c69b870 100644