Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread Luiz Capitulino
On Wed, 2 Jul 2014 16:20:47 -0700 (PDT) David Rientjes wrote: > On Wed, 2 Jul 2014, Luiz Capitulino wrote: > > > > With this patch, the dmesg changes break one of my scripts that we use to > > > determine the start and end address of a node (doubly bad because there's > > > no sysfs interface

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread David Rientjes
On Wed, 2 Jul 2014, Luiz Capitulino wrote: > > With this patch, the dmesg changes break one of my scripts that we use to > > determine the start and end address of a node (doubly bad because there's > > no sysfs interface to determine this otherwise and we have to do this at > > boot to

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread Luiz Capitulino
On Mon, 30 Jun 2014 16:42:39 -0700 (PDT) David Rientjes wrote: > On Thu, 19 Jun 2014, Luiz Capitulino wrote: > > > The setup_node_data() function allocates a pg_data_t object, inserts it > > into the node_data[] array and initializes the following fields: > > node_id, node_start_pfn and

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread Luiz Capitulino
On Mon, 30 Jun 2014 16:42:39 -0700 (PDT) David Rientjes rient...@google.com wrote: On Thu, 19 Jun 2014, Luiz Capitulino wrote: The setup_node_data() function allocates a pg_data_t object, inserts it into the node_data[] array and initializes the following fields: node_id, node_start_pfn

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread David Rientjes
On Wed, 2 Jul 2014, Luiz Capitulino wrote: With this patch, the dmesg changes break one of my scripts that we use to determine the start and end address of a node (doubly bad because there's no sysfs interface to determine this otherwise and we have to do this at boot to acquire the

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-07-02 Thread Luiz Capitulino
On Wed, 2 Jul 2014 16:20:47 -0700 (PDT) David Rientjes rient...@google.com wrote: On Wed, 2 Jul 2014, Luiz Capitulino wrote: With this patch, the dmesg changes break one of my scripts that we use to determine the start and end address of a node (doubly bad because there's no sysfs

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-30 Thread David Rientjes
On Thu, 19 Jun 2014, Luiz Capitulino wrote: > The setup_node_data() function allocates a pg_data_t object, inserts it > into the node_data[] array and initializes the following fields: > node_id, node_start_pfn and node_spanned_pages. > > However, a few function calls later during the kernel

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-30 Thread David Rientjes
On Thu, 19 Jun 2014, Luiz Capitulino wrote: The setup_node_data() function allocates a pg_data_t object, inserts it into the node_data[] array and initializes the following fields: node_id, node_start_pfn and node_spanned_pages. However, a few function calls later during the kernel boot,

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Rik van Riel
On 06/26/2014 11:05 AM, Luiz Capitulino wrote: > On Thu, 26 Jun 2014 10:51:11 -0400 > Rik van Riel wrote: > > On 06/19/2014 10:20 PM, Luiz Capitulino wrote: > @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) end = max(mi->blk[i].end, end); }

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 10:51:11 -0400 Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/19/2014 10:20 PM, Luiz Capitulino wrote: > > > @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct > > numa_meminfo *mi) end = max(mi->blk[i].end, end); } > > > >

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/19/2014 10:20 PM, Luiz Capitulino wrote: > @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct > numa_meminfo *mi) end = max(mi->blk[i].end, end); } > > - if (start < end) - setup_node_data(nid,

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/19/2014 10:20 PM, Luiz Capitulino wrote: @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) end = max(mi-blk[i].end, end); } - if (start end) - setup_node_data(nid,

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Luiz Capitulino
On Thu, 26 Jun 2014 10:51:11 -0400 Rik van Riel r...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/19/2014 10:20 PM, Luiz Capitulino wrote: @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) end = max(mi-blk[i].end, end); }

Re: [PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-26 Thread Rik van Riel
On 06/26/2014 11:05 AM, Luiz Capitulino wrote: On Thu, 26 Jun 2014 10:51:11 -0400 Rik van Riel r...@redhat.com wrote: On 06/19/2014 10:20 PM, Luiz Capitulino wrote: @@ -523,8 +508,17 @@ static int __init numa_register_memblks(struct numa_meminfo *mi) end = max(mi-blk[i].end, end); } -

[PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-19 Thread Luiz Capitulino
The setup_node_data() function allocates a pg_data_t object, inserts it into the node_data[] array and initializes the following fields: node_id, node_start_pfn and node_spanned_pages. However, a few function calls later during the kernel boot, free_area_init_node() re-initializes those fields,

[PATCH] x86: numa: setup_node_data(): drop dead code and rename function

2014-06-19 Thread Luiz Capitulino
The setup_node_data() function allocates a pg_data_t object, inserts it into the node_data[] array and initializes the following fields: node_id, node_start_pfn and node_spanned_pages. However, a few function calls later during the kernel boot, free_area_init_node() re-initializes those fields,