Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-26 Thread Yinghai Lu
On Mon, Feb 25, 2008 at 11:33 PM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: > >> which is the same. set_cpu_cap() is indeed the cleaner form to do this > >> so your patch is correct as a cleanup. > > set_cpu_cap is right > > == > > set_bit(X86_FEATURE_CONSTANT_TSC, &c->x8

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-26 Thread Ingo Molnar
* H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Yinghai Lu wrote: >>> which is the same. set_cpu_cap() is indeed the cleaner form to do this >>> so your patch is correct as a cleanup. >> set_cpu_cap is right >> == >> set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong >> should b

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread H. Peter Anvin
Yinghai Lu wrote: which is the same. set_cpu_cap() is indeed the cleaner form to do this so your patch is correct as a cleanup. set_cpu_cap is right == set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong should be set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); x86_capa

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > set_cpu_cap is right > > == > > set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong > > should be > > set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability); > > > > x86_capability is a array ... > > > > so this could prevent some data

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > > #define set_cpu_cap(c, bit) set_bit(bit, (unsigned long > > *)((c)->x86_capability) > > > > which is the same. set_cpu_cap() is indeed the cleaner form to do this > > so your patch is correct as a cleanup. > set_cpu_cap is right > == > set_bit(

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Yinghai Lu
On Mon, Feb 25, 2008 at 11:20 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > > also fix error in early_init_intel and reference about x86_capality, > > because it is array already.., prevent possible data corruption... > > hm, why should there be dat

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > also fix error in early_init_intel and reference about x86_capality, > because it is array already.., prevent possible data corruption... hm, why should there be data corruption: > - set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); >

Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > early_init_intel is introduced by > > commit 2b16a2353814a513cdb5c5c739b76a19d7ea39ce > Author: Andi Kleen <[EMAIL PROTECTED]> > Date: Wed Jan 30 13:32:40 2008 +0100 > > x86: move X86_FEATURE_CONSTANT_TSC into early cpu feature detection > > set

[PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

2008-02-25 Thread Yinghai Lu
early_init_intel is introduced by commit 2b16a2353814a513cdb5c5c739b76a19d7ea39ce Author: Andi Kleen <[EMAIL PROTECTED]> Date: Wed Jan 30 13:32:40 2008 +0100 x86: move X86_FEATURE_CONSTANT_TSC into early cpu feature detection set CONSTANT_TSC for intel cpus but it already set in init_inte