Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: This isn't a problem with things like "Signed-off-by:" etc tags, because they have no automated meaning and don't really change the commit itself, but the "From:"/"Date:"/"Subject:" markers at the head of the message really do have real meaning, and get removed from the co

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Linus Torvalds
On Fri, 22 Feb 2008, Andi Kleen wrote: > > Linus Torvalds <[EMAIL PROTECTED]> writes: > > > > (*) I keed, I keed. Of *course* I'll have to fix things like this in the > > future too. But hopefully not quite as often. > > The pragmatic solution would be to just fix the scripts to accept From > e

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Andi Kleen
Linus Torvalds <[EMAIL PROTECTED]> writes: > > (*) I keed, I keed. Of *course* I'll have to fix things like this in the > future too. But hopefully not quite as often. The pragmatic solution would be to just fix the scripts to accept From everywhere @) -Andi -- To unsubscribe from this list: sen

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: OK. Have you fixed it, or shall I resend? I'll fix it, but I want people to know so that I don't have to fix things like this in the future (*). Linus (*) I keed, I keed. Of *course* I'll

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Linus Torvalds
On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: > > OK. Have you fixed it, or shall I resend? I'll fix it, but I want people to know so that I don't have to fix things like this in the future (*). Linus (*) I keed, I keed. Of *course* I'll have to fix things like thi

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> From: Ian Campbell <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> This is just wrong. The From: goes at the *top*, and if it's not there, m

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Linus Torvalds
On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: > > Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> > From: Ian Campbell <[EMAIL PROTECTED]> > Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> This is just wrong. The From: goes at the *top*, and if it's not there, my scripts won't pick it

[PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
The below implements the getgeo hook for Xen block devices. Extracted from the xen-unstable tree where it has been used for ages. It is useful to have because it allows things like grub2 (used by the Debian installer images) to work in a guest domain without having to sprinkle Xen specific hacks