[PATCH]is_power_of_2-ufs/super.c

2007-06-14 Thread vignesh babu
Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 22ff6ed..2b30116 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c @@ -87,6 +87,7 @@ #include #include #include

Re: [PATCH]is_power_of_2-ufs/super.c

2007-06-14 Thread Evgeniy Dushistov
On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote: > > > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 > > Signed-off-by: vignesh babu <[EMAIL PROTECTED]> Acked-by: Evgeniy Dushistov <[EMAIL PROTECTED]> > --- > diff --git a/fs/ufs/super.c b/fs/ufs/s

Re: [PATCH]is_power_of_2-ufs/super.c

2007-06-25 Thread Johannes Weiner
Hi, On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote: > Replacing (n & (n-1)) in the context of power of 2 checks > with is_power_of_2 You might want to run egrep -R '([a-zA-Z0-9_.>]+) *& *\(\1 *- *1\)' /usr/src/linux This does not match if the check is broken into multiple

Re: [PATCH]is_power_of_2-ufs/super.c

2007-06-25 Thread vignesh babu
Thanks Hannes, Im on it... On Mon, 2007-06-25 at 14:13 +0200, Johannes Weiner wrote: > egrep -R '([a-zA-Z0-9_.>]+) *& *\(\1 *- *1\)' /usr/src/linux -- Vignesh Babu BM _ "Why is it that every time I'm with you, makes me believe in magic

Re: [PATCH]is_power_of_2-ufs/super.c

2007-06-25 Thread Robert P. J. Day
On Mon, 25 Jun 2007, Johannes Weiner wrote: > Hi, > > On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote: > > Replacing (n & (n-1)) in the context of power of 2 checks > > with is_power_of_2 > > You might want to run > > egrep -R '([a-zA-Z0-9_.>]+) *& *\(\1 *- *1\)' /usr/src/linux