Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-12 Thread Dan Streetman
On Thu, 8 Feb 2018, Minchan Kim wrote: > Hi Huang, > > On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: > > On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > > > From: Huang Ying > > > > > > It was reported by Sergey

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-12 Thread Dan Streetman
On Thu, 8 Feb 2018, Minchan Kim wrote: > Hi Huang, > > On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: > > On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > > > From: Huang Ying > > > > > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > > > Page) and

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: >> On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: >> > From: Huang Ying >> > >> > It was reported by Sergey Senozhatsky

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: >> On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: >> > From: Huang Ying >> > >> > It was reported by Sergey Senozhatsky that if THP (Transparent Huge >> > Page) and frontswap (via zswap) are

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
Hi Huang, On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: > On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > > From: Huang Ying > > > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > > Page) and frontswap

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
Hi Huang, On Thu, Feb 08, 2018 at 11:27:50PM +0800, huang ying wrote: > On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > > From: Huang Ying > > > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > > Page) and frontswap (via zswap) are both enabled, when memory goes low

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread huang ying
On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered,

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread huang ying
On Wed, Feb 7, 2018 at 3:00 PM, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and memory corruption will occur > in

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread huang ying
On Thu, Feb 8, 2018 at 6:17 PM, Minchan Kim wrote: > On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> It was reported by Sergey Senozhatsky that if THP (Transparent Huge >> Page) and frontswap (via zswap) are

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread huang ying
On Thu, Feb 8, 2018 at 6:17 PM, Minchan Kim wrote: > On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: >> From: Huang Ying >> >> It was reported by Sergey Senozhatsky that if THP (Transparent Huge >> Page) and frontswap (via zswap) are both enabled, when memory goes low >> so that

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Sergey Senozhatsky
On (02/08/18 02:25), Minchan Kim wrote: [..] > > > if (PageTransHuge(page)) { > > > - if (IS_ENABLED(CONFIG_THP_SWAP)) > > > - get_swap_pages(1, true, ); > > > + /* Frontswap doesn't support THP */ > > > + if (!frontswap_enabled()) { > > > +

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Sergey Senozhatsky
On (02/08/18 02:25), Minchan Kim wrote: [..] > > > if (PageTransHuge(page)) { > > > - if (IS_ENABLED(CONFIG_THP_SWAP)) > > > - get_swap_pages(1, true, ); > > > + /* Frontswap doesn't support THP */ > > > + if (!frontswap_enabled()) { > > > +

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
On Thu, Feb 08, 2018 at 10:36:35AM +0900, Sergey Senozhatsky wrote: > On (02/07/18 13:05), Andrew Morton wrote: > [..] > > hm. This is assuming that "cluster==true" means "this is thp swap". > > That's presently true, but is it appropriate that get_swap_pages() is > > peeking at "cluster" to

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
On Thu, Feb 08, 2018 at 10:36:35AM +0900, Sergey Senozhatsky wrote: > On (02/07/18 13:05), Andrew Morton wrote: > [..] > > hm. This is assuming that "cluster==true" means "this is thp swap". > > That's presently true, but is it appropriate that get_swap_pages() is > > peeking at "cluster" to

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-08 Thread Minchan Kim
On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and memory corruption will occur

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Sergey Senozhatsky
On (02/07/18 13:05), Andrew Morton wrote: [..] > hm. This is assuming that "cluster==true" means "this is thp swap". > That's presently true, but is it appropriate that get_swap_pages() is > peeking at "cluster" to work out why it is being called? > > Or would it be cleaner to do this in

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Sergey Senozhatsky
On (02/07/18 13:05), Andrew Morton wrote: [..] > hm. This is assuming that "cluster==true" means "this is thp swap". > That's presently true, but is it appropriate that get_swap_pages() is > peeking at "cluster" to work out why it is being called? > > Or would it be cleaner to do this in

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Huang, Ying
Andrew Morton writes: > On Wed, 7 Feb 2018 15:00:35 +0800 "Huang, Ying" wrote: > >> From: Huang Ying >> >> It was reported by Sergey Senozhatsky that if THP (Transparent Huge >> Page) and frontswap (via zswap) are

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Huang, Ying
Andrew Morton writes: > On Wed, 7 Feb 2018 15:00:35 +0800 "Huang, Ying" wrote: > >> From: Huang Ying >> >> It was reported by Sergey Senozhatsky that if THP (Transparent Huge >> Page) and frontswap (via zswap) are both enabled, when memory goes low >> so that swap is triggered, segfault and

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Andrew Morton
On Wed, 7 Feb 2018 15:00:35 +0800 "Huang, Ying" wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Andrew Morton
On Wed, 7 Feb 2018 15:00:35 +0800 "Huang, Ying" wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and memory corruption will occur >

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Konrad Rzeszutek Wilk
On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and

Re: [PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-07 Thread Konrad Rzeszutek Wilk
On Wed, Feb 07, 2018 at 03:00:35PM +0800, Huang, Ying wrote: > From: Huang Ying > > It was reported by Sergey Senozhatsky that if THP (Transparent Huge > Page) and frontswap (via zswap) are both enabled, when memory goes low > so that swap is triggered, segfault and memory corruption will occur

[PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-06 Thread Huang, Ying
From: Huang Ying It was reported by Sergey Senozhatsky that if THP (Transparent Huge Page) and frontswap (via zswap) are both enabled, when memory goes low so that swap is triggered, segfault and memory corruption will occur in random user space applications as

[PATCH -mm -v2] mm, swap, frontswap: Fix THP swap if frontswap enabled

2018-02-06 Thread Huang, Ying
From: Huang Ying It was reported by Sergey Senozhatsky that if THP (Transparent Huge Page) and frontswap (via zswap) are both enabled, when memory goes low so that swap is triggered, segfault and memory corruption will occur in random user space applications as follow, kernel: urxvt[338]: