Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Alexander Potapenko
On Fri, Jun 21, 2019 at 4:56 PM Qian Cai wrote: > > On Fri, 2019-06-21 at 16:37 +0200, Alexander Potapenko wrote: > > On Fri, Jun 21, 2019 at 2:26 PM Qian Cai wrote: > > > > > > On Fri, 2019-06-21 at 12:39 +0200, Alexander Potapenko wrote: > > > > On Fri, Jun 21, 2019 at 3:01 AM Kees Cook

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Qian Cai
On Fri, 2019-06-21 at 16:37 +0200, Alexander Potapenko wrote: > On Fri, Jun 21, 2019 at 2:26 PM Qian Cai wrote: > > > > On Fri, 2019-06-21 at 12:39 +0200, Alexander Potapenko wrote: > > > On Fri, Jun 21, 2019 at 3:01 AM Kees Cook wrote: > > > > > > > > On Thu, Jun 20, 2019 at 04:46:06PM -0400,

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Alexander Potapenko
On Fri, Jun 21, 2019 at 2:26 PM Qian Cai wrote: > > On Fri, 2019-06-21 at 12:39 +0200, Alexander Potapenko wrote: > > On Fri, Jun 21, 2019 at 3:01 AM Kees Cook wrote: > > > > > > On Thu, Jun 20, 2019 at 04:46:06PM -0400, Qian Cai wrote: > > > > The linux-next commit "mm: security: introduce

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Qian Cai
On Fri, 2019-06-21 at 12:39 +0200, Alexander Potapenko wrote: > On Fri, Jun 21, 2019 at 3:01 AM Kees Cook wrote: > > > > On Thu, Jun 20, 2019 at 04:46:06PM -0400, Qian Cai wrote: > > > The linux-next commit "mm: security: introduce init_on_alloc=1 and > > > init_on_free=1 boot options" [1]

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-21 Thread Alexander Potapenko
On Fri, Jun 21, 2019 at 3:01 AM Kees Cook wrote: > > On Thu, Jun 20, 2019 at 04:46:06PM -0400, Qian Cai wrote: > > The linux-next commit "mm: security: introduce init_on_alloc=1 and > > init_on_free=1 boot options" [1] introduced a false positive when > > init_on_free=1 and page_poison=on, due to

Re: [PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-20 Thread Kees Cook
On Thu, Jun 20, 2019 at 04:46:06PM -0400, Qian Cai wrote: > The linux-next commit "mm: security: introduce init_on_alloc=1 and > init_on_free=1 boot options" [1] introduced a false positive when > init_on_free=1 and page_poison=on, due to the page_poison expects the > pattern 0xaa when allocating

[PATCH -next v2] mm/page_alloc: fix a false memory corruption

2019-06-20 Thread Qian Cai
The linux-next commit "mm: security: introduce init_on_alloc=1 and init_on_free=1 boot options" [1] introduced a false positive when init_on_free=1 and page_poison=on, due to the page_poison expects the pattern 0xaa when allocating pages which were overwritten by init_on_free=1 with 0. Fix it by