Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-19 Thread Dan Williams
On Tue, Apr 18, 2017 at 12:54 PM, Michal Hocko wrote: > On Tue 18-04-17 09:42:57, Dan Williams wrote: >> On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko wrote: >> > On Mon 17-04-17 14:51:12, Dan Williams wrote: >> >> On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: >> >> > All the reported i

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-18 Thread Michal Hocko
On Tue 18-04-17 09:42:57, Dan Williams wrote: > On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko wrote: > > On Mon 17-04-17 14:51:12, Dan Williams wrote: > >> On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: > >> > All the reported issue seem to be fixed and pushed to my git tree > >> > attemp

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 12:14 AM, Michal Hocko wrote: > On Mon 17-04-17 14:51:12, Dan Williams wrote: >> On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: >> > All the reported issue seem to be fixed and pushed to my git tree >> > attempts/rewrite-mem_hotplug branch. I will wait a day or two

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-18 Thread Vlastimil Babka
On 04/10/2017 06:02 PM, Michal Hocko wrote: > On Mon 10-04-17 16:27:49, Igor Mammedov wrote: > [...] >> #issue3: >> removable flag flipped to non-removable state >> >> // before series at commit ef0b577b6: >> memory32:offline removable: 0 zones: Normal Movable >> memory33:offline removable: 0 zon

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-18 Thread Michal Hocko
On Mon 17-04-17 14:51:12, Dan Williams wrote: > On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: > > All the reported issue seem to be fixed and pushed to my git tree > > attempts/rewrite-mem_hotplug branch. I will wait a day or two for more > > feedback and then repost for the inclusion. I w

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-17 Thread Dan Williams
On Tue, Apr 11, 2017 at 10:03 AM, Michal Hocko wrote: > All the reported issue seem to be fixed and pushed to my git tree > attempts/rewrite-mem_hotplug branch. I will wait a day or two for more > feedback and then repost for the inclusion. I would really appreaciate > more testing/review! This s

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
All the reported issue seem to be fixed and pushed to my git tree attempts/rewrite-mem_hotplug branch. I will wait a day or two for more feedback and then repost for the inclusion. I would really appreaciate more testing/review! -- Michal Hocko SUSE Labs

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 13:38:16, Michal Hocko wrote: > On Tue 11-04-17 13:01:43, Michal Hocko wrote: > > On Tue 11-04-17 11:59:31, Igor Mammedov wrote: > > > On Tue, 11 Apr 2017 11:23:07 +0200 > > > Michal Hocko wrote: > > > > > > > On Tue 11-04-17 08:38:34, Igor Mammedov wrote: > > > > > for issue2: >

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 13:01:43, Michal Hocko wrote: > On Tue 11-04-17 11:59:31, Igor Mammedov wrote: > > On Tue, 11 Apr 2017 11:23:07 +0200 > > Michal Hocko wrote: > > > > > On Tue 11-04-17 08:38:34, Igor Mammedov wrote: > > > > for issue2: > > > > -enable-kvm -m 2G,slots=4,maxmem=4G -smp 4 -numa node

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 11:59:31, Igor Mammedov wrote: > On Tue, 11 Apr 2017 11:23:07 +0200 > Michal Hocko wrote: > > > On Tue 11-04-17 08:38:34, Igor Mammedov wrote: > > > for issue2: > > > -enable-kvm -m 2G,slots=4,maxmem=4G -smp 4 -numa node -numa node \ > > > -drive if=virtio,file=disk.img -kernel bz

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 11:53:22, Igor Mammedov wrote: > On Tue, 11 Apr 2017 10:41:42 +0200 > Michal Hocko wrote: > > > On Tue 11-04-17 10:01:52, Igor Mammedov wrote: > > > On Mon, 10 Apr 2017 16:56:39 +0200 > > > Michal Hocko wrote: > > [...] > > > > > #echo online_kernel > memory32/state > > > > > w

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Igor Mammedov
On Tue, 11 Apr 2017 11:23:07 +0200 Michal Hocko wrote: > On Tue 11-04-17 08:38:34, Igor Mammedov wrote: > > for issue2: > > -enable-kvm -m 2G,slots=4,maxmem=4G -smp 4 -numa node -numa node \ > > -drive if=virtio,file=disk.img -kernel bzImage -append 'root=/dev/vda1' \ > > -object memory-backend-r

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Igor Mammedov
On Tue, 11 Apr 2017 10:41:42 +0200 Michal Hocko wrote: > On Tue 11-04-17 10:01:52, Igor Mammedov wrote: > > On Mon, 10 Apr 2017 16:56:39 +0200 > > Michal Hocko wrote: > [...] > > > > #echo online_kernel > memory32/state > > > > write error: Invalid argument > > > > // that's not what's expecte

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 08:38:34, Igor Mammedov wrote: > for issue2: > -enable-kvm -m 2G,slots=4,maxmem=4G -smp 4 -numa node -numa node \ > -drive if=virtio,file=disk.img -kernel bzImage -append 'root=/dev/vda1' \ > -object memory-backend-ram,id=mem1,size=256M -object > memory-backend-ram,id=mem0,size=256

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Mon 10-04-17 10:43:04, Reza Arbab wrote: > On Mon, Apr 10, 2017 at 01:03:42PM +0200, Michal Hocko wrote: > >This patchset aims at making the onlining semantic more usable. First of > >all it allows to online memory movable as long as it doesn't clash with > >the existing ZONE_NORMAL. That means

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Michal Hocko
On Tue 11-04-17 10:01:52, Igor Mammedov wrote: > On Mon, 10 Apr 2017 16:56:39 +0200 > Michal Hocko wrote: [...] > > > #echo online_kernel > memory32/state > > > write error: Invalid argument > > > // that's not what's expected > > > > this is proper behavior with the current implementation. Doe

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-11 Thread Igor Mammedov
On Mon, 10 Apr 2017 16:56:39 +0200 Michal Hocko wrote: > On Mon 10-04-17 16:27:49, Igor Mammedov wrote: > [...] > > Hi Michal, > > > > I've given series some dumb testing, see below for unexpected changes I've > > noticed. > > > > Using the same CLI as above plus hotpluggable dimms present at

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Igor Mammedov
On Mon, 10 Apr 2017 18:09:41 +0200 Michal Hocko wrote: > On Mon 10-04-17 16:27:49, Igor Mammedov wrote: > [...] > > -object memory-backend-ram,id=mem1,size=256M -object > > memory-backend-ram,id=mem0,size=256M \ > > -device pc-dimm,id=dimm1,memdev=mem1,slot=1,node=0 -device > > pc-dimm,id=dimm0

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Balbir Singh
On Mon, 2017-04-10 at 12:35 -0400, Jerome Glisse wrote: > On Mon, Apr 10, 2017 at 01:03:42PM +0200, Michal Hocko wrote: > > Hi, > > The last version of this series has been posted here [1]. It has seen > > some more serious testing (thanks to Reza Arbab) and fixes for the found > > issues. I have a

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
On Mon 10-04-17 12:35:53, Jerome Glisse wrote: > On Mon, Apr 10, 2017 at 01:03:42PM +0200, Michal Hocko wrote: > > Hi, > > The last version of this series has been posted here [1]. It has seen > > some more serious testing (thanks to Reza Arbab) and fixes for the found > > issues. I have also decid

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Jerome Glisse
On Mon, Apr 10, 2017 at 01:03:42PM +0200, Michal Hocko wrote: > Hi, > The last version of this series has been posted here [1]. It has seen > some more serious testing (thanks to Reza Arbab) and fixes for the found > issues. I have also decided to drop patch 1 [2] because it turned out to > be more

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
On Mon 10-04-17 16:27:49, Igor Mammedov wrote: [...] > -object memory-backend-ram,id=mem1,size=256M -object > memory-backend-ram,id=mem0,size=256M \ > -device pc-dimm,id=dimm1,memdev=mem1,slot=1,node=0 -device > pc-dimm,id=dimm0,memdev=mem0,slot=0,node=0 are you sure both of them should be node=

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
On Mon 10-04-17 16:27:49, Igor Mammedov wrote: [...] > #issue3: > removable flag flipped to non-removable state > > // before series at commit ef0b577b6: > memory32:offline removable: 0 zones: Normal Movable > memory33:offline removable: 0 zones: Normal Movable > memory34:offline removable: 0 z

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Reza Arbab
On Mon, Apr 10, 2017 at 01:03:42PM +0200, Michal Hocko wrote: This patchset aims at making the onlining semantic more usable. First of all it allows to online memory movable as long as it doesn't clash with the existing ZONE_NORMAL. That means that ZONE_NORMAL and ZONE_MOVABLE cannot overlap. C

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
On Mon 10-04-17 17:22:28, Michal Hocko wrote: [...] > Heh, this one is embarrassing > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 1c6fdacbccd3..9677b6b711b0 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -402,7 +402,7 @@ static ssize_t show_valid_zone

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
[dropping Lai Jiangshan whose email bounces] On Mon 10-04-17 16:56:39, Michal Hocko wrote: > On Mon 10-04-17 16:27:49, Igor Mammedov wrote: > [...] > > Hi Michal, > > > > I've given series some dumb testing, see below for unexpected changes I've > > noticed. > > > > Using the same CLI as above

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
On Mon 10-04-17 16:27:49, Igor Mammedov wrote: [...] > Hi Michal, > > I've given series some dumb testing, see below for unexpected changes I've > noticed. > > Using the same CLI as above plus hotpluggable dimms present at startup > (it still uses hotplug path as dimms aren't reported in e820) >

Re: [PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Igor Mammedov
On Mon, 10 Apr 2017 13:03:42 +0200 Michal Hocko wrote: > Hi, > The last version of this series has been posted here [1]. It has seen > some more serious testing (thanks to Reza Arbab) and fixes for the found > issues. I have also decided to drop patch 1 [2] because it turned out to > be more comp

[PATCH -v2 0/9] mm: make movable onlining suck less

2017-04-10 Thread Michal Hocko
Hi, The last version of this series has been posted here [1]. It has seen some more serious testing (thanks to Reza Arbab) and fixes for the found issues. I have also decided to drop patch 1 [2] because it turned out to be more complicated than I initially thought [3]. Few more patches were added t