* Peter Ujfalusi [181213 06:52]:
> On 12/12/2018 16.50, Tony Lindgren wrote:
> > * Peter Ujfalusi [181212 13:03]:
> >> On 12/12/2018 2.19, Tony Lindgren wrote:
> >>> In my McBSP case there is only a single physical I2S port
> >>> that can be TDM split into timeslots.
> >>
> >> So what is missing
On 12/12/2018 16.50, Tony Lindgren wrote:
> * Peter Ujfalusi [181212 13:03]:
>> On 12/12/2018 2.19, Tony Lindgren wrote:
>>> In my McBSP case there is only a single physical I2S port
>>> that can be TDM split into timeslots.
>>
>> So what is missing from the McBSP driver is to configure the
* Kuninori Morimoto [181213 01:06]:
>
> Hi Tony
>
> > > According to OF graph maintainer, he said that
> > > counting port / endpoint are not guaranteed,
> > > and we need to use "reg".
> > > (It is the reason of b6f3fc005a2c8b425d7a0973b43bef05890bf479)
> > >
> > > If you could double
Hi Tony
> > According to OF graph maintainer, he said that
> > counting port / endpoint are not guaranteed,
> > and we need to use "reg".
> > (It is the reason of b6f3fc005a2c8b425d7a0973b43bef05890bf479)
> >
> > If you could double checked, and we could agreed
> > that "reg" is the solution
* Kuninori Morimoto [181213 00:24]:
> (snip)
> > foo = < 0>;
> > bar = < 1>;
>
> Ahh, it looks nice idea !
> but hmm..., it seems dtc doesn't allow us to use #address-cells = <2>
> for "remote-endpoint".
OK. Yeah let's scrap that then, it does not suit for
endpoints it seems. Thanks for
Hi Tony
> /* Codec has 1 DAI */
> Codec {
> port {
> #address-cells = <2>;
> #size-cells = <1>;
>
> ep: endpoint {
> remote-endpoint = ;
> };
>
* Kuninori Morimoto [181212 06:52]:
>
> Hi Tony, again
>
> > > > https://patchwork.kernel.org/patch/10712877/
> > >
> > > Hmm, so do you have multiple separate ports at the "" node
> > > hardware? If so then yeah multiple ports make sense.
> > >
> > > But if you only a single physical
* Peter Ujfalusi [181212 12:47]:
> McBSP have single DX and single DR pin. Iow each McBSP have single DAI.
Yeah it's single physical port for sure. But at least currently we need
additional secondary DAIs for each TDM channel in addition to the primary
DAI managing the McBSP registers.
* Peter Ujfalusi [181212 13:03]:
> On 12/12/2018 2.19, Tony Lindgren wrote:
> > In my McBSP case there is only a single physical I2S port
> > that can be TDM split into timeslots.
>
> So what is missing from the McBSP driver is to configure the TDM. We
> never had a hardware which would require
On 12/12/2018 2.19, Tony Lindgren wrote:
> * Kuninori Morimoto [181211 23:16]:
>>
>> Hi Tony
>>
>>> The issue I have with that it does not then follow the binding doc :)
>>>
>>> See this part in Documentation/devicetree/bindings/graph.txt:
>>>
>>> "If a single port is connected to more than
On 11/12/2018 7.35, Tony Lindgren wrote:
> * Kuninori Morimoto [181211 05:16]:
>>
>> Hi Tony
>>
This looks a little bit strange for me.
Can you show me your DT for it ?
>>>
>>> Sure, adding also Sebastian to Cc. Here's what I currently have for droid 4
>>> dts with two codecs on I2S.
Hi Tony, again
> > > https://patchwork.kernel.org/patch/10712877/
> >
> > Hmm, so do you have multiple separate ports at the "" node
> > hardware? If so then yeah multiple ports make sense.
> >
> > But if you only a single physical (I2S?) port at the
> > "" node hardware, then IMO you should
Hi Tony
> > https://patchwork.kernel.org/patch/10712877/
>
> Hmm, so do you have multiple separate ports at the "" node
> hardware? If so then yeah multiple ports make sense.
>
> But if you only a single physical (I2S?) port at the
> "" node hardware, then IMO you should only have one
>
* Tony Lindgren [181212 00:43]:
> The other McBSP instance is dedicated for SoC audio:
>
> CPCAP PMIC codec1-endpoint---McBSP3 on SoC
Sorry this should be McBSP2, not McBSP3 above for
the SoC dedicated audio port.
Tony
* Kuninori Morimoto [181212 00:12]:
>
> Hi Tony, again
>
> > > The issue I have with that it does not then follow the binding doc :)
> > >
> > > See this part in Documentation/devicetree/bindings/graph.txt:
> > >
> > > "If a single port is connected to more than one remote device, an
> > >
* Kuninori Morimoto [181211 23:16]:
>
> Hi Tony
>
> > The issue I have with that it does not then follow the binding doc :)
> >
> > See this part in Documentation/devicetree/bindings/graph.txt:
> >
> > "If a single port is connected to more than one remote device, an
> > 'endpoint' child
Hi Tony, again
> > The issue I have with that it does not then follow the binding doc :)
> >
> > See this part in Documentation/devicetree/bindings/graph.txt:
> >
> > "If a single port is connected to more than one remote device, an
> > 'endpoint' child node must be provided for each link."
Hi Tony
> The issue I have with that it does not then follow the binding doc :)
>
> See this part in Documentation/devicetree/bindings/graph.txt:
>
> "If a single port is connected to more than one remote device, an
> 'endpoint' child node must be provided for each link."
>
> Isn't the I2C
Hi,
* Kuninori Morimoto [181211 06:14]:
>
> Hi Tony
>
> > > And, your [2/2] patch,
> > > I guess you are misunderstanding about "port" vs "endpoint",
> > > or omap-mcbsp driver side need to update ?
> >
> > Yes omap-mcbsp driver needs to be updated for multiple endpoints.
> >
> > Adding
Hi Tony
> > And, your [2/2] patch,
> > I guess you are misunderstanding about "port" vs "endpoint",
> > or omap-mcbsp driver side need to update ?
>
> Yes omap-mcbsp driver needs to be updated for multiple endpoints.
>
> Adding Jarkko and Peter also to Cc, below is the WIP patch that I'm
>
* Kuninori Morimoto [181211 05:30]:
>
> Hi Tony, again
>
> > > mcbsp3_port: port {
> > > - cpu_dai3: endpoint {
> > > + cpu_dai3: endpoint@0 {
> > > dai-format = "dsp_a";
> > > frame-master = <_audio_codec1>;
> > >
* Kuninori Morimoto [181211 05:16]:
>
> Hi Tony
>
> > > This looks a little bit strange for me.
> > > Can you show me your DT for it ?
> >
> > Sure, adding also Sebastian to Cc. Here's what I currently have for droid 4
> > dts with two codecs on I2S. Please just ignore the GNSS parts there..
>
Hi Tony, again
> > mcbsp3_port: port {
> > - cpu_dai3: endpoint {
> > + cpu_dai3: endpoint@0 {
> > dai-format = "dsp_a";
> > frame-master = <_audio_codec1>;
> > bitclock-master = <_audio_codec1>;
> >
Hi Tony
> > This looks a little bit strange for me.
> > Can you show me your DT for it ?
>
> Sure, adding also Sebastian to Cc. Here's what I currently have for droid 4
> dts with two codecs on I2S. Please just ignore the GNSS parts there..
>
> The TDM configuration is all done in the
* Kuninori Morimoto [181211 03:31]:
>
> Hi Tony
>
> > Here are two fixes that allow me to have multiple endpoints defined in
> > the dts file for audio-graph-card. To do that, we need to fix up few
> > issues as the graph binding Documentation/devicetree/bindings/graph.txt
> > allows multiple
Hi Tony
> Here are two fixes that allow me to have multiple endpoints defined in
> the dts file for audio-graph-card. To do that, we need to fix up few
> issues as the graph binding Documentation/devicetree/bindings/graph.txt
> allows multiple endpoints per port. This allows configuring TDM
Hi all,
Here are two fixes that allow me to have multiple endpoints defined in
the dts file for audio-graph-card. To do that, we need to fix up few
issues as the graph binding Documentation/devicetree/bindings/graph.txt
allows multiple endpoints per port. This allows configuring TDM codecs
for
27 matches
Mail list logo
