Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-20 Thread Lee Jones
On Tue, 19 Aug 2014, Brian Norris wrote: > On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: > > On Thu, 14 Aug 2014, Brian Norris wrote: > > > drivers/mtd/nand/stm_nand_bch.c: In function 'bch_calc_timing_registers': > > > drivers/mtd/nand/stm_nand_bch.c:1022:6: warning: variable

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-20 Thread Lee Jones
On Mon, 18 Aug 2014, Brian Norris wrote: > On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: > > On Thu, 14 Aug 2014, Brian Norris wrote: > > > Particularly, take a hard look at rewriting > > > include/linux/mtd/stm_nand_bbt.h. > > > > I don't think there is any need - although this

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-20 Thread Lee Jones
On Mon, 18 Aug 2014, Brian Norris wrote: On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: On Thu, 14 Aug 2014, Brian Norris wrote: Particularly, take a hard look at rewriting include/linux/mtd/stm_nand_bbt.h. I don't think there is any need - although this change is

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-20 Thread Lee Jones
On Tue, 19 Aug 2014, Brian Norris wrote: On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: On Thu, 14 Aug 2014, Brian Norris wrote: drivers/mtd/nand/stm_nand_bch.c: In function 'bch_calc_timing_registers': drivers/mtd/nand/stm_nand_bch.c:1022:6: warning: variable 'ren_half_off'

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-19 Thread Brian Norris
On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: > On Thu, 14 Aug 2014, Brian Norris wrote: > > drivers/mtd/nand/stm_nand_bch.c: In function 'bch_calc_timing_registers': > > drivers/mtd/nand/stm_nand_bch.c:1022:6: warning: variable 'ren_half_off' > > set but not used

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-19 Thread Brian Norris
On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: On Thu, 14 Aug 2014, Brian Norris wrote: drivers/mtd/nand/stm_nand_bch.c: In function 'bch_calc_timing_registers': drivers/mtd/nand/stm_nand_bch.c:1022:6: warning: variable 'ren_half_off' set but not used

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Brian Norris
On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: > On Thu, 14 Aug 2014, Brian Norris wrote: > > Particularly, take a hard look at rewriting > > include/linux/mtd/stm_nand_bbt.h. > > I don't think there is any need - although this change is required: > > -#if defined(MTD_NAND_STM_BBT) >

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Lee Jones
> > Particularly, take a hard look at rewriting > > include/linux/mtd/stm_nand_bbt.h. > > I don't think there is any need - although this change is required: > > -#if defined(MTD_NAND_STM_BBT) > +#if defined(MTD_NAND_STM_BCH_BBT) Sorry, I mean this: -#if defined(MTD_NAND_STM_BBT) +#if

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Lee Jones
On Thu, 14 Aug 2014, Brian Norris wrote: > On Wed, Aug 13, 2014 at 10:11:59AM +0100, Lee Jones wrote: > > Hi Brian, Pekon, > > > > I believe all of your queries have either been answered or addressed > > and I am hoping this will be the last submission. :) > > > > /me crosses fingers! > > > >

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Lee Jones
On Thu, 14 Aug 2014, Brian Norris wrote: On Wed, Aug 13, 2014 at 10:11:59AM +0100, Lee Jones wrote: Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards,

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Lee Jones
Particularly, take a hard look at rewriting include/linux/mtd/stm_nand_bbt.h. I don't think there is any need - although this change is required: -#if defined(MTD_NAND_STM_BBT) +#if defined(MTD_NAND_STM_BCH_BBT) Sorry, I mean this: -#if defined(MTD_NAND_STM_BBT) +#if

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-18 Thread Brian Norris
On Mon, Aug 18, 2014 at 09:39:53AM +0100, Lee Jones wrote: On Thu, 14 Aug 2014, Brian Norris wrote: Particularly, take a hard look at rewriting include/linux/mtd/stm_nand_bbt.h. I don't think there is any need - although this change is required: -#if defined(MTD_NAND_STM_BBT) +#if

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-14 Thread Brian Norris
On Wed, Aug 13, 2014 at 10:11:59AM +0100, Lee Jones wrote: > Hi Brian, Pekon, > > I believe all of your queries have either been answered or addressed > and I am hoping this will be the last submission. :) > > /me crosses fingers! > > Kind regards, > Lee I didn't look through the patches yet,

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-14 Thread Brian Norris
On Wed, Aug 13, 2014 at 10:11:59AM +0100, Lee Jones wrote: Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards, Lee I didn't look through the patches yet, but my

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-13 Thread pekon
Hello Lee, On Wednesday 13 August 2014 02:41 PM, Lee Jones wrote: Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards, Lee Lee Jones (8): ARM: multi-v7: Enable ST BCH

[PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-13 Thread Lee Jones
Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards, Lee Lee Jones (8): ARM: multi-v7: Enable ST BCH NAND ARM: sti: Add two new clock definitions for use with ST's NAND

[PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-13 Thread Lee Jones
Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards, Lee Lee Jones (8): ARM: multi-v7: Enable ST BCH NAND ARM: sti: Add two new clock definitions for use with ST's NAND

Re: [PATCH 0/8] mtd: nand: Support for new DT NAND driver

2014-08-13 Thread pekon
Hello Lee, On Wednesday 13 August 2014 02:41 PM, Lee Jones wrote: Hi Brian, Pekon, I believe all of your queries have either been answered or addressed and I am hoping this will be the last submission. :) /me crosses fingers! Kind regards, Lee Lee Jones (8): ARM: multi-v7: Enable ST BCH