Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-23 Thread Ingo Molnar
* Dave Hansen wrote: > On 11/23/2017 10:35 PM, Ingo Molnar wrote: > > So the pteval_t changes break the build on most non-x86 architectures > > (alpha, arm, > > arm64, etc.), because most of them don't have an asm/pgtable_types.h file. > > > > pteval_t is an x86-ism. > > > > So I left out th

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-23 Thread Dave Hansen
On 11/23/2017 10:35 PM, Ingo Molnar wrote: > So the pteval_t changes break the build on most non-x86 architectures (alpha, > arm, > arm64, etc.), because most of them don't have an asm/pgtable_types.h file. > > pteval_t is an x86-ism. > > So I left out the changes below. There was a warning on

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-23 Thread Ingo Molnar
* Dave Hansen wrote: > I've updated these a bit since yesterday with some minor fixes: > * Fixed KASLR compile bug > * Fixed ds.c compile problem > * Changed ulong to pteval_t to fix 32-bit compile problem > * Stop mapping cpu_current_top_of_stack (never used until after CR3 switch) > > Rat

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-23 Thread Dave Hansen
I've updated these a bit since yesterday with some minor fixes: * Fixed KASLR compile bug * Fixed ds.c compile problem * Changed ulong to pteval_t to fix 32-bit compile problem * Stop mapping cpu_current_top_of_stack (never used until after CR3 switch) Rather than re-spamming everyone, the res

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-23 Thread Dave Hansen
On 11/22/2017 11:32 PM, Ingo Molnar wrote: > diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c > index c9f44d7ce838..61388b01962d 100644 > --- a/arch/x86/events/intel/ds.c > +++ b/arch/x86/events/intel/ds.c > @@ -3,7 +3,7 @@ > #include > #include > > -#include > +#include

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-22 Thread Ingo Molnar
* Ingo Molnar wrote: > > 32-bit x86 defconfig still doesn't build: > > arch/x86/events/intel/ds.c: In function ‘dsalloc’: > arch/x86/events/intel/ds.c:296:6: error: implicit declaration of function > ‘kaiser_add_mapping’; did you mean ‘kgid_has_mapping’? > [-Werror=implicit-function-declar

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-22 Thread Ingo Molnar
32-bit x86 defconfig still doesn't build: arch/x86/events/intel/ds.c: In function ‘dsalloc’: arch/x86/events/intel/ds.c:296:6: error: implicit declaration of function ‘kaiser_add_mapping’; did you mean ‘kgid_has_mapping’? [-Werror=implicit-function-declaration] Also, could you please use pro

Re: [PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-22 Thread Ingo Molnar
* Dave Hansen wrote: > Thanks, everyone for all the reviews thus far. I hope I managed to > address all the feedback given so far, except for the TODOs of > course. This is a pretty minor update compared to v1->v2. > > These patches are all on this tip branch: > > > https://git.kernel

[PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-22 Thread Dave Hansen
Thanks, everyone for all the reviews thus far. I hope I managed to address all the feedback given so far, except for the TODOs of course. This is a pretty minor update compared to v1->v2. These patches are all on this tip branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.