Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-22 Thread Jiri Olsa
On Fri, Jan 22, 2016 at 07:43:12PM +0900, Namhyung Kim wrote: > Hi Jiri, > > On Thu, Jan 21, 2016 at 02:35:58PM +0100, Jiri Olsa wrote: > > On Thu, Jan 21, 2016 at 09:55:52PM +0900, Namhyung Kim wrote: > > > > would it make more sense to do this in 'in-tree addition' path? > > > > and keep the res

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-22 Thread Namhyung Kim
Hi Arnaldo, On Thu, Jan 21, 2016 at 11:02:09AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jan 21, 2016 at 02:35:58PM +0100, Jiri Olsa escreveu: > > On Thu, Jan 21, 2016 at 09:55:52PM +0900, Namhyung Kim wrote: > > > > SNIP > > > > > > > + /* insert copy of 'he' for each fmt int

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-22 Thread Namhyung Kim
Hi Jiri, On Thu, Jan 21, 2016 at 02:35:58PM +0100, Jiri Olsa wrote: > On Thu, Jan 21, 2016 at 09:55:52PM +0900, Namhyung Kim wrote: > > > would it make more sense to do this in 'in-tree addition' path? > > > and keep the resort functions to do only resort stuff > > > > I don't follow. There're 3

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 21, 2016 at 02:35:58PM +0100, Jiri Olsa escreveu: > On Thu, Jan 21, 2016 at 09:55:52PM +0900, Namhyung Kim wrote: > > SNIP > > > > > + /* insert copy of 'he' for each fmt into the hierarchy > > > > */ > > > > + new = hierarchy_insert_entry(hists, root, he,

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Jiri Olsa
On Thu, Jan 21, 2016 at 09:55:52PM +0900, Namhyung Kim wrote: SNIP > > > + /* insert copy of 'he' for each fmt into the hierarchy */ > > > + new = hierarchy_insert_entry(hists, root, he, fmt); > > > + if (new == NULL) > > > + break; > > > > so hierarchy_in

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Namhyung Kim
On Thu, Jan 21, 2016 at 12:35:11PM +0100, Jiri Olsa wrote: > On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: > > SNIP > > > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h > > index 687bbb124428..15a75d44de91 100644 > > --- a/tools/perf/util/sort.h > > +++ b/tools/perf/

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Namhyung Kim
Hi Jiri, On Thu, Jan 21, 2016 at 11:43:30AM +0100, Jiri Olsa wrote: > On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: > > SNIP > > > +} > > + > > +static bool hists__hierarchy_insert_entry(struct hists *hists, > > + struct rb_root *root, > > +

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Jiri Olsa
On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h > index 687bbb124428..15a75d44de91 100644 > --- a/tools/perf/util/sort.h > +++ b/tools/perf/util/sort.h > @@ -94,9 +94,11 @@ struct hist_entry { > s32

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-21 Thread Jiri Olsa
On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: SNIP > +} > + > +static bool hists__hierarchy_insert_entry(struct hists *hists, > + struct rb_root *root, > + struct hist_entry *he) > +{ > + struct perf_h

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-20 Thread Namhyung Kim
Hi Jiri, On Wed, Jan 20, 2016 at 06:00:59PM +0100, Jiri Olsa wrote: > On Tue, Jan 19, 2016 at 01:50:47PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 19, 2016 at 07:51:18PM +0900, Namhyung Kim escreveu: > > > Hi Jiri, > > > > > > On Sun, Jan 17, 2016 at 05:15:33PM +0100, Jiri Olsa wrote

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-20 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 20, 2016 at 06:00:59PM +0100, Jiri Olsa escreveu: > On Tue, Jan 19, 2016 at 01:50:47PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 19, 2016 at 07:51:18PM +0900, Namhyung Kim escreveu: > > > Hi Jiri, > > > > > > On Sun, Jan 17, 2016 at 05:15:33PM +0100, Jiri Olsa wrote: > > >

Re: [PATCH 01/17] perf hists: Basic support of hierarchical report view

2016-01-20 Thread Jiri Olsa
On Tue, Jan 19, 2016 at 01:50:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 19, 2016 at 07:51:18PM +0900, Namhyung Kim escreveu: > > Hi Jiri, > > > > On Sun, Jan 17, 2016 at 05:15:33PM +0100, Jiri Olsa wrote: > > > On Sun, Jan 17, 2016 at 01:03:01AM +0900, Namhyung Kim wrote: > > > >