Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Sat, May 19, 2018 at 5:05 AM, Joe Perches wrote: > On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote: >> On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: >> > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: >> > > On Thu 2018-05-10

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Sat, May 19, 2018 at 5:05 AM, Joe Perches wrote: > On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote: >> On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: >> > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: >> > > On Thu 2018-05-10 08:45:29, Joe Perches wrote: >> > > [

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote: > On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: > > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: > > > On Thu 2018-05-10 08:45:29, Joe Perches wrote: > > > [0.00] libftrace: ftrace: allocating

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-18 at 23:29 +0300, Andy Shevchenko wrote: > On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: > > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: > > > On Thu 2018-05-10 08:45:29, Joe Perches wrote: > > > [0.00] libftrace: ftrace: allocating 40753 entries in 160

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: >> On Thu 2018-05-10 08:45:29, Joe Perches wrote: >> [0.00] libftrace: ftrace: allocating 40753 entries in 160 pages >> [0.004008] apic: APIC: Switch to

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, May 18, 2018 at 12:10 PM, Joe Perches wrote: > On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: >> On Thu 2018-05-10 08:45:29, Joe Perches wrote: >> [0.00] libftrace: ftrace: allocating 40753 entries in 160 pages >> [0.004008] apic: APIC: Switch to symmetric I/O mode

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: > On Thu 2018-05-10 08:45:29, Joe Perches wrote: > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Make that the default define so these uses can be removed later via script. > > > > Signed-off-by: Joe

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-18 at 10:42 +0200, Petr Mladek wrote: > On Thu 2018-05-10 08:45:29, Joe Perches wrote: > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Make that the default define so these uses can be removed later via script. > > > > Signed-off-by: Joe

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu 2018-05-10 08:45:29, Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches It removes a lot of duplicates. I just

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu 2018-05-10 08:45:29, Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches It removes a lot of duplicates. I just hope that we will not

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 11:41 +0900, Sergey Senozhatsky wrote: > On (05/10/18 19:33), Joe Perches wrote: > > > > > > [ 28.420519] generic: RSP: 0018:a01dc062bda8 EFLAGS: 00010282 > > > [ 28.420522] generic: RAX: 8317612f RBX: ffea RCX: > > > a01dc062bdc8 > > > [

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 11:41 +0900, Sergey Senozhatsky wrote: > On (05/10/18 19:33), Joe Perches wrote: > > > > > > [ 28.420519] generic: RSP: 0018:a01dc062bda8 EFLAGS: 00010282 > > > [ 28.420522] generic: RAX: 8317612f RBX: ffea RCX: > > > a01dc062bdc8 > > > [

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 19:33), Joe Perches wrote: > > > > [ 28.420519] generic: RSP: 0018:a01dc062bda8 EFLAGS: 00010282 > > [ 28.420522] generic: RAX: 8317612f RBX: ffea RCX: > > a01dc062bdc8 > > [ 28.420523] generic: RDX: 55a6a3f03110 RSI: 0001 RDI: > >

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 19:33), Joe Perches wrote: > > > > [ 28.420519] generic: RSP: 0018:a01dc062bda8 EFLAGS: 00010282 > > [ 28.420522] generic: RAX: 8317612f RBX: ffea RCX: > > a01dc062bdc8 > > [ 28.420523] generic: RDX: 55a6a3f03110 RSI: 0001 RDI: > >

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 11:23 +0900, Sergey Senozhatsky wrote: > On (05/11/18 10:51), Sergey Senozhatsky wrote: > > In general, the idea looks OK to me, so FWIW > > Acked-by: Sergey Senozhatsky > > Looking at dmesg, > > Base: > [0.00] KERNEL supported cpus: >

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 11:23 +0900, Sergey Senozhatsky wrote: > On (05/11/18 10:51), Sergey Senozhatsky wrote: > > In general, the idea looks OK to me, so FWIW > > Acked-by: Sergey Senozhatsky > > Looking at dmesg, > > Base: > [0.00] KERNEL supported cpus: > [0.00] Intel

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 18:57), Joe Perches wrote: > > What about them? > > All those defines above are non-generic as they are > specified to start with "OF: " and then some optional > extra bit. > > Why should these defines be updated or modified? Nevermind, my bad. I, for some reason, assumed that you

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 18:57), Joe Perches wrote: > > What about them? > > All those defines above are non-generic as they are > specified to start with "OF: " and then some optional > extra bit. > > Why should these defines be updated or modified? Nevermind, my bad. I, for some reason, assumed that you

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/11/18 10:51), Sergey Senozhatsky wrote: > In general, the idea looks OK to me, so FWIW > Acked-by: Sergey Senozhatsky Looking at dmesg, Base: [0.00] KERNEL supported cpus: [0.00] Intel GenuineIntel [...] [0.00] 0-9

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/11/18 10:51), Sergey Senozhatsky wrote: > In general, the idea looks OK to me, so FWIW > Acked-by: Sergey Senozhatsky Looking at dmesg, Base: [0.00] KERNEL supported cpus: [0.00] Intel GenuineIntel [...] [0.00] 0-9 write-back [0.00]

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu, 2018-05-10 at 18:57 -0700, Joe Perches wrote: > On Fri, 2018-05-11 at 10:51 +0900, Sergey Senozhatsky wrote: > > On (05/10/18 08:45), Joe Perches wrote: > > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " > > > fmt > > > Make that the default define so these

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu, 2018-05-10 at 18:57 -0700, Joe Perches wrote: > On Fri, 2018-05-11 at 10:51 +0900, Sergey Senozhatsky wrote: > > On (05/10/18 08:45), Joe Perches wrote: > > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " > > > fmt > > > Make that the default define so these

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 10:51 +0900, Sergey Senozhatsky wrote: > On (05/10/18 08:45), Joe Perches wrote: > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Make that the default define so these uses can be removed later via script. > > > > Signed-off-by: Joe

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Fri, 2018-05-11 at 10:51 +0900, Sergey Senozhatsky wrote: > On (05/10/18 08:45), Joe Perches wrote: > > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > Make that the default define so these uses can be removed later via script. > > > > Signed-off-by: Joe

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 08:45), Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches In general, the idea looks OK to me, so FWIW

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On (05/10/18 08:45), Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches In general, the idea looks OK to me, so FWIW Acked-by: Sergey

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu, 10 May 2018 08:45:29 -0700 Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches > --- >

Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

On Thu, 10 May 2018 08:45:29 -0700 Joe Perches wrote: > There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > Make that the default define so these uses can be removed later via script. > > Signed-off-by: Joe Perches > --- > include/linux/printk.h | 2 +- > 1 file

[PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Make that the default define so these uses can be removed later via script. Signed-off-by: Joe Perches --- include/linux/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Make that the default define so these uses can be removed later via script. Signed-off-by: Joe Perches --- include/linux/printk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git