Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Yu-cheng Yu
On Mon, Jan 30, 2017 at 04:45:21PM +0100, Borislav Petkov wrote: > On Mon, Jan 30, 2017 at 10:57:28AM +0100, Ingo Molnar wrote: > > Would anyone object to using u32 in these prototypes? > > Well, would there be any disadvantage to forcing them to u32? > Potentially by something else wanting to

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Yu-cheng Yu
On Mon, Jan 30, 2017 at 04:45:21PM +0100, Borislav Petkov wrote: > On Mon, Jan 30, 2017 at 10:57:28AM +0100, Ingo Molnar wrote: > > Would anyone object to using u32 in these prototypes? > > Well, would there be any disadvantage to forcing them to u32? > Potentially by something else wanting to

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Borislav Petkov
On Mon, Jan 30, 2017 at 10:57:28AM +0100, Ingo Molnar wrote: > Would anyone object to using u32 in these prototypes? Well, would there be any disadvantage to forcing them to u32? Potentially by something else wanting to use those interfaces besides the regset thing and that something else doesn't

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Borislav Petkov
On Mon, Jan 30, 2017 at 10:57:28AM +0100, Ingo Molnar wrote: > Would anyone object to using u32 in these prototypes? Well, would there be any disadvantage to forcing them to u32? Potentially by something else wanting to use those interfaces besides the regset thing and that something else doesn't

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Jan 26, 2017 at 11:22:49AM +0100, Ingo Molnar wrote: > > The 'kbuf' parameter is unused in the _user() side of the API, remove it. > > > > This simplifies the code and makes it easier to think about. > > ... > > > @@ -1010,10 +1010,7 @@ int

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-30 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Jan 26, 2017 at 11:22:49AM +0100, Ingo Molnar wrote: > > The 'kbuf' parameter is unused in the _user() side of the API, remove it. > > > > This simplifies the code and makes it easier to think about. > > ... > > > @@ -1010,10 +1010,7 @@ int

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-27 Thread Borislav Petkov
On Thu, Jan 26, 2017 at 11:22:49AM +0100, Ingo Molnar wrote: > The 'kbuf' parameter is unused in the _user() side of the API, remove it. > > This simplifies the code and makes it easier to think about. ... > @@ -1010,10 +1010,7 @@ int copy_xstate_to_kernel(unsigned int pos, unsigned > int

Re: [PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-27 Thread Borislav Petkov
On Thu, Jan 26, 2017 at 11:22:49AM +0100, Ingo Molnar wrote: > The 'kbuf' parameter is unused in the _user() side of the API, remove it. > > This simplifies the code and makes it easier to think about. ... > @@ -1010,10 +1010,7 @@ int copy_xstate_to_kernel(unsigned int pos, unsigned > int

[PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-26 Thread Ingo Molnar
The 'kbuf' parameter is unused in the _user() side of the API, remove it. This simplifies the code and makes it easier to think about. Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Dave Hansen Cc: Fenghua Yu

[PATCH 04/14] x86/fpu: Remove 'kbuf' parameter from the copy_xstate_to_user() APIs

2017-01-26 Thread Ingo Molnar
The 'kbuf' parameter is unused in the _user() side of the API, remove it. This simplifies the code and makes it easier to think about. Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Dave Hansen Cc: Fenghua Yu Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Oleg Nesterov Cc: Rik van Riel Cc: