Re: [PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-18 Thread Namhyung Kim
Hi Jiri, On Wed, 18 Dec 2013 16:50:40 +0100, Jiri Olsa wrote: > On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> There're some duplicate code when adding hist entries. They are >> different in that some have branch info or mem info but generally do >>

Re: [PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-18 Thread Jiri Olsa
On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > There're some duplicate code when adding hist entries. They are > different in that some have branch info or mem info but generally do > same thing. So introduce new struct add_entry_iter and add callbacks >

Re: [PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-18 Thread Jiri Olsa
On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but generally do same thing. So introduce new struct add_entry_iter and

Re: [PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-18 Thread Namhyung Kim
Hi Jiri, On Wed, 18 Dec 2013 16:50:40 +0100, Jiri Olsa wrote: On Wed, Dec 18, 2013 at 02:21:12PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but

[PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-17 Thread Namhyung Kim
From: Namhyung Kim There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but generally do same thing. So introduce new struct add_entry_iter and add callbacks to customize each case in general way. The new perf_evsel__add_entry()

[PATCH 04/18] perf tools: Introduce struct add_entry_iter

2013-12-17 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com There're some duplicate code when adding hist entries. They are different in that some have branch info or mem info but generally do same thing. So introduce new struct add_entry_iter and add callbacks to customize each case in general way. The new