Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Dong Aisheng
On Sun, Jun 12, 2016 at 9:29 PM, Shawn Guo wrote: > On Sun, Jun 12, 2016 at 08:13:03PM +0800, Dong Aisheng wrote: >> I understand your point. >> How about using power_bit and powerup_set? >> * @power_bit: pll power bit offset > > I'm fine with the name, but the comment should be fixed, since we

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Shawn Guo
On Sun, Jun 12, 2016 at 08:13:03PM +0800, Dong Aisheng wrote: > I understand your point. > How about using power_bit and powerup_set? > * @power_bit: pll power bit offset I'm fine with the name, but the comment should be fixed, since we are actually using it as a bit mask instead of offset. Sha

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Dong Aisheng
On Sun, Jun 12, 2016 at 07:36:27PM +0800, Shawn Guo wrote: > On Wed, Jun 08, 2016 at 10:33:34PM +0800, Dong Aisheng wrote: > > There's a powerdown bit already, so let's change the name of > > powerup_set bit to power_invert to reflects the power polarity > > to make it less confusing. > > > > Sign

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Dong Aisheng
On Thu, Jun 09, 2016 at 09:43:28AM +0200, Lothar Wa??mann wrote: > Hi, > > On Wed, 8 Jun 2016 22:33:34 +0800 Dong Aisheng wrote: > > There's a powerdown bit already, so let's change the name of > > powerup_set bit to power_invert to reflects the power polarity > > to make it less confusing. > > >

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Dong Aisheng
Hi Shawn, On Sun, Jun 12, 2016 at 07:36:27PM +0800, Shawn Guo wrote: > On Wed, Jun 08, 2016 at 10:33:34PM +0800, Dong Aisheng wrote: > > There's a powerdown bit already, so let's change the name of > > powerup_set bit to power_invert to reflects the power polarity > > to make it less confusing. >

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-12 Thread Shawn Guo
On Wed, Jun 08, 2016 at 10:33:34PM +0800, Dong Aisheng wrote: > There's a powerdown bit already, so let's change the name of > powerup_set bit to power_invert to reflects the power polarity > to make it less confusing. > > Signed-off-by: Dong Aisheng > --- > drivers/clk/imx/clk-pllv3.c | 14

Re: [PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-09 Thread Lothar Waßmann
Hi, On Wed, 8 Jun 2016 22:33:34 +0800 Dong Aisheng wrote: > There's a powerdown bit already, so let's change the name of > powerup_set bit to power_invert to reflects the power polarity > to make it less confusing. > > Signed-off-by: Dong Aisheng > --- > drivers/clk/imx/clk-pllv3.c | 14 +++

[PATCH 05/11] clk: imx: refine the powerup_set bit of clk-pllv3

2016-06-08 Thread Dong Aisheng
There's a powerdown bit already, so let's change the name of powerup_set bit to power_invert to reflects the power polarity to make it less confusing. Signed-off-by: Dong Aisheng --- drivers/clk/imx/clk-pllv3.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dr