Re: [PATCH 06/11] wm8350-core: Fix probable mask then right shift defect

2014-11-03 Thread Lee Jones
On Sun, 26 Oct 2014, Joe Perches wrote: > Precedence of & and >> is not the same and is not left to right. > shift has higher precedence and should be done after the mask. > > Add parentheses around the mask. > > Signed-off-by: Joe Perches > --- > drivers/mfd/wm8350-core.c | 2 +- > 1 file cha

Re: [PATCH 06/11] wm8350-core: Fix probable mask then right shift defect

2014-10-27 Thread Charles Keepax
On Sun, Oct 26, 2014 at 10:25:02PM -0700, Joe Perches wrote: > Precedence of & and >> is not the same and is not left to right. > shift has higher precedence and should be done after the mask. > > Add parentheses around the mask. > > Signed-off-by: Joe Perches > --- Acked-by: Charles Keepax T

[PATCH 06/11] wm8350-core: Fix probable mask then right shift defect

2014-10-26 Thread Joe Perches
Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Signed-off-by: Joe Perches --- drivers/mfd/wm8350-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/m