Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-20 Thread Jiri Olsa
On Tue, May 20, 2014 at 02:22:21AM +, Namhyung Kim wrote: > Jiri, > > I updated my -v6 branch to fix the breakage - move the hunk to 15/20. > Do you want me to resend or would you review with this thread > directly? Either way would be find to me. np, I can take it from branch jirka -- To u

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-19 Thread Namhyung Kim
Jiri, I updated my -v6 branch to fix the breakage - move the hunk to 15/20. Do you want me to resend or would you review with this thread directly? Either way would be find to me. Thanks, Namhyung On Mon, May 19, 2014 at 1:54 PM, Namhyung Kim wrote: > 2014-05-19 (월), 15:12 +0200, Jiri Olsa: >

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-19 Thread Namhyung Kim
2014-05-19 (월), 15:12 +0200, Jiri Olsa: > On Mon, May 19, 2014 at 03:25:48PM +0900, Namhyung Kim wrote: > > SNIP > > > @@ -1104,27 +1104,35 @@ static int hist_browser__fprintf_entry(struct > > hist_browser *browser, > >struct hist_entry *he, FILE *fp) > > { >

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-19 Thread Jiri Olsa
On Mon, May 19, 2014 at 03:25:48PM +0900, Namhyung Kim wrote: SNIP > @@ -1104,27 +1104,35 @@ static int hist_browser__fprintf_entry(struct > hist_browser *browser, > struct hist_entry *he, FILE *fp) > { > char s[8192]; > - double percent; > i

[PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-18 Thread Namhyung Kim
Until now the hpp and sort functions do similar jobs different ways. Since the sort functions converted/wrapped to hpp formats it can do the job in a uniform way. The perf_hpp__sort_list has a list of hpp formats to sort entries and the perf_hpp__list has a list of hpp formats to print output resu

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-15 Thread Namhyung Kim
On Thu, 15 May 2014 14:11:52 +0200, Jiri Olsa wrote: > On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote: > > SNIP > >> diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c >> index 9eccf7f4f367..e6920d124c60 100644 >> --- a/tools/perf/ui/stdio/hist.c >> +++ b/tools/perf/

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-15 Thread Namhyung Kim
On Thu, 15 May 2014 14:07:04 +0200, Jiri Olsa wrote: > On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote: > > SNIP > >> -} >> - >> if (symbol_conf.use_callchain && sort__has_sym) { >> if (callchain_param.mode == CHAIN_GRAPH_REL) >>

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-15 Thread Jiri Olsa
On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c > index 9eccf7f4f367..e6920d124c60 100644 > --- a/tools/perf/ui/stdio/hist.c > +++ b/tools/perf/ui/stdio/hist.c > @@ -353,8 +353,7 @@ static int hist_entry__fp

Re: [PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-15 Thread Jiri Olsa
On Mon, May 12, 2014 at 03:28:39PM +0900, Namhyung Kim wrote: SNIP > - } > - > if (symbol_conf.use_callchain && sort__has_sym) { > if (callchain_param.mode == CHAIN_GRAPH_REL) > total = h->stat.period; > diff --git a/to

[PATCH 06/20] perf tools: Consolidate output field handling to hpp format routines

2014-05-11 Thread Namhyung Kim
Until now the hpp and sort functions do similar jobs different ways. Since the sort functions converted/wrapped to hpp formats it can do the job in a uniform way. The perf_hpp__sort_list has a list of hpp formats to sort entries and the perf_hpp__list has a list of hpp formats to print output resu