Re: [PATCH 08/21] TTY: hci_ldisc, remove invalid check in open

2012-10-18 Thread Marcel Holtmann
Hi Jiri, > hci_ldisc's open checks if tty_struct->disc_data is set. And if so it > returns with an error. But nothing ensures disc_data to be NULL. And > since ld->ops->open shall be called only once, we do not need the > check at all. So remove it. > > Note that this is not an issue now, but n_t

[PATCH 08/21] TTY: hci_ldisc, remove invalid check in open

2012-10-18 Thread Jiri Slaby
hci_ldisc's open checks if tty_struct->disc_data is set. And if so it returns with an error. But nothing ensures disc_data to be NULL. And since ld->ops->open shall be called only once, we do not need the check at all. So remove it. Note that this is not an issue now, but n_tty will start using th