Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-08-08 Thread Alexander Holler
Am 08.08.2014 20:11, schrieb Ezequiel Garcia: On 08 Aug 10:16 AM, Brian Norris wrote: On Fri, Aug 08, 2014 at 02:04:28PM -0300, Ezequiel Garcia wrote: If there's anything left to fix for this driver, please let me know. pxa3xx_nand is still missing a parent for its MTD's (mtd->dev.parent).

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-08-08 Thread Ezequiel Garcia
On 08 Aug 10:16 AM, Brian Norris wrote: > On Fri, Aug 08, 2014 at 02:04:28PM -0300, Ezequiel Garcia wrote: > > If there's anything left to fix for this driver, please let me know. > > pxa3xx_nand is still missing a parent for its MTD's (mtd->dev.parent). I > have a follow-up patch queued up local

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-08-08 Thread Brian Norris
On Fri, Aug 08, 2014 at 02:04:28PM -0300, Ezequiel Garcia wrote: > Picking on this old thread... > > On 27 May 07:12 AM, Alexander Shiyan wrote: > > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c > > > b/drivers/mtd/nand/pxa3xx_nand.c > > > index 7588fe2..7f62e7c 100644 > > > --- a/drivers/mtd/nan

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-08-08 Thread Ezequiel Garcia
Picking on this old thread... On 27 May 07:12 AM, Alexander Shiyan wrote: > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > > index 7588fe2..7f62e7c 100644 > > --- a/drivers/mtd/nand/pxa3xx_nand.c > > +++ b/drivers/mtd/nand/pxa3xx_nand.c > > @@ -1584,8 +1584,7 @@ s

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-05-28 Thread Brian Norris
On Tue, May 27, 2014 at 08:01:55AM +0200, Alexander Holler wrote: > Am 27.05.2014 05:12, schrieb Alexander Shiyan: > >Should we add "driver.owner = THIS_MODULE" field for struct platform_driver > >in this case? > > Yes. I assumed all drivers/modules already had an owner. I will > check them all a

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-05-26 Thread Alexander Holler
Am 27.05.2014 05:12, schrieb Alexander Shiyan: Tue, 27 May 2014 00:12:34 +0200 от Alexander Holler : Fix a common error in nand-drivers which do not set up a parent devicefor the mtd-device by using a new inline function. Signed-off-by: Alexander Holler --- drivers/mtd/nand/pxa3xx_nand.c | 3

Re: [PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-05-26 Thread Alexander Shiyan
Tue, 27 May 2014 00:12:34 +0200 от Alexander Holler : > Fix a common error in nand-drivers which do not set up a parent device for > the mtd-device by using a new inline function. > > Signed-off-by: Alexander Holler > --- > drivers/mtd/nand/pxa3xx_nand.c | 3 +-- > 1 file changed, 1 insertion(+)

[PATCH 09/27] mtd: nand: pxa3xx: show device structure in sysfs

2014-05-26 Thread Alexander Holler
Fix a common error in nand-drivers which do not set up a parent device for the mtd-device by using a new inline function. Signed-off-by: Alexander Holler --- drivers/mtd/nand/pxa3xx_nand.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/driv