Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Greg KH
On Tue, Aug 02, 2016 at 04:34:20PM +0300, Matwey V. Kornilov wrote: > And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH can be simplified > to S_IRUGO | S_IWUSR, not? > I think we need to have and use dedicated special macros for most > common magic octal permissions like 0755 or 0644. We alread

Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Matwey V. Kornilov
Hello, I believe that 0644 is shorter and easier to read and understand than the long list of macros like S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH where it is easier to miss something. 2016-08-02 15:03 GMT+03:00 Baole Ni : > I find that the developers often just specified the numeric value > when ca

Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Matwey V. Kornilov
And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH can be simplified to S_IRUGO | S_IWUSR, not? I think we need to have and use dedicated special macros for most common magic octal permissions like 0755 or 0644. 2016-08-02 16:19 GMT+03:00 Matwey V. Kornilov : > Hello, > > I believe that 0644 is s

[PATCH 0967/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of