Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-02-05 Thread Mike Frysinger
On Jan 30, 2008 6:00 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 01/30/2008 11:36 AM, Bryan Wu wrote: > > + > > + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1); > > + if (ret) { > > + unregister_chrdev_region(bfin_otp_dev_node, 1); > > + printk(KERN_ERR PFX

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Jiri Slaby
On 01/30/2008 02:43 PM, Jiri Slaby wrote: specified one (like a v4l or tty layer, or chrdev_open aswell, which Eh, no, not the tty layer... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Mike Frysinger
On Jan 30, 2008 8:38 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 01/30/2008 02:19 PM, Mike Frysinger wrote: > > On Jan 30, 2008 6:00 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> On 01/30/2008 11:36 AM, Bryan Wu wrote: > >>> + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1); > >>> +

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Jiri Slaby
On 01/30/2008 02:15 PM, Bryan Wu wrote: And one question for Jiri, what is the difference between misc char driver with other char drivers. No difference in behaviour. Open function in misc replaces fops by your specified one (like a v4l or tty layer, or chrdev_open aswell, which will be call

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Jiri Slaby
On 01/30/2008 02:19 PM, Mike Frysinger wrote: On Jan 30, 2008 6:00 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: On 01/30/2008 11:36 AM, Bryan Wu wrote: + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1); + if (ret) { + unregister_chrdev_region(bfin_otp_dev_node, 1); +

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Mike Frysinger
On Jan 30, 2008 6:00 AM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > On 01/30/2008 11:36 AM, Bryan Wu wrote: > > +DEFINE_MUTEX(bfin_otp_lock); > > static? the macro threw me ... fixed now, thanks > > +static int __init bfin_otp_init(void) > > +{ > > + int ret; > > + > > + stampit(); > > + > >

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Bryan Wu
On Jan 30, 2008 8:39 PM, Robin Getz <[EMAIL PROTECTED]> wrote: > On Wed 30 Jan 2008 06:00, Jiri Slaby pondered: > > On 01/30/2008 11:36 AM, Bryan Wu wrote: > > > From: Mike Frysinger <[EMAIL PROTECTED]> > > > > > > initial char driver for otp memory > > > (only read supported atm ... needs real exa

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Jiri Slaby
On 01/30/2008 01:39 PM, Robin Getz wrote: On Wed 30 Jan 2008 06:00, Jiri Slaby pondered: On 01/30/2008 11:36 AM, Bryan Wu wrote: From: Mike Frysinger <[EMAIL PROTECTED]> initial char driver for otp memory (only read supported atm ... needs real examples/docs for write support) Signed-off-by:

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Robin Getz
On Wed 30 Jan 2008 06:00, Jiri Slaby pondered: > On 01/30/2008 11:36 AM, Bryan Wu wrote: > > From: Mike Frysinger <[EMAIL PROTECTED]> > > > > initial char driver for otp memory > > (only read supported atm ... needs real examples/docs for write support) > > > > Signed-off-by: Mike Frysinger <[EMA

Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Jiri Slaby
On 01/30/2008 11:36 AM, Bryan Wu wrote: From: Mike Frysinger <[EMAIL PROTECTED]> initial char driver for otp memory (only read supported atm ... needs real examples/docs for write support) Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers

[PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory

2008-01-30 Thread Bryan Wu
From: Mike Frysinger <[EMAIL PROTECTED]> initial char driver for otp memory (only read supported atm ... needs real examples/docs for write support) Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/char/Kconfig| 28 +++ drivers/c