Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, Herbert Xu wrote: > On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote: > > > > How so? The reason you changed it to sg_init_table() + sg_set_buf() is > > exactly because sg_init_one() didn't properly init the entry (as they > > name promised). > > For one of the cases

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-30 Thread Herbert Xu
On Tue, Oct 30, 2007 at 06:50:58AM +0100, Jens Axboe wrote: > > How so? The reason you changed it to sg_init_table() + sg_set_buf() is > exactly because sg_init_one() didn't properly init the entry (as they > name promised). For one of the cases yes but the other one repeatedly calls sg_init_one o

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-30 Thread Jens Axboe
On Tue, Oct 30 2007, Boaz Harrosh wrote: > On Mon, Oct 29 2007 at 22:16 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > > On Fri, Oct 26 2007, Herbert Xu wrote: > >> [CRYPTO] tcrypt: Move sg_init_table out of timing loops > >> > >> This patch moves the sg_init_table out of the timing loops for hash

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-30 Thread Boaz Harrosh
On Mon, Oct 29 2007 at 22:16 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Fri, Oct 26 2007, Herbert Xu wrote: >> [CRYPTO] tcrypt: Move sg_init_table out of timing loops >> >> This patch moves the sg_init_table out of the timing loops for hash >> algorithms so that it doesn't impact on the spee

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Jens Axboe
On Tue, Oct 30 2007, Herbert Xu wrote: > On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > > On Fri, Oct 26 2007, Herbert Xu wrote: > > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > > > This patch moves the sg_init_table out of the timing loops for hash > > > algori

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Herbert Xu
On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > On Fri, Oct 26 2007, Herbert Xu wrote: > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > This patch moves the sg_init_table out of the timing loops for hash > > algorithms so that it doesn't impact on the speed test re

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Jens Axboe
On Fri, Oct 26 2007, Herbert Xu wrote: > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > This patch moves the sg_init_table out of the timing loops for hash > algorithms so that it doesn't impact on the speed test results. Wouldn't it be better to just make sg_init_one() call sg_init_

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-27 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 23:00:04 +0800 > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > This patch moves the sg_init_table out of the timing loops for hash > algorithms so that it doesn't impact on the speed test results. > > Signed-off-by: Herber

[PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-26 Thread Herbert Xu
[CRYPTO] tcrypt: Move sg_init_table out of timing loops This patch moves the sg_init_table out of the timing loops for hash algorithms so that it doesn't impact on the speed test results. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- crypto/tcrypt.c | 20 ++-- 1 files chan