Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2014-01-16 Thread Wolfram Sang
> >You can also use the gcc-ism, which is a bit more concise: > > > > sda_falling_time = dev->sda_falling_time ?: 300; > > +1 ditto signature.asc Description: Digital signature

Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2013-10-13 Thread Shinya Kuribayashi
On 10/10/13 9:54 AM, Ryan Mallon wrote: On 09/10/13 18:55, Mika Westerberg wrote: On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote: @@ -307,15 +309,25 @@ int i2c_dw_init(struct dw_i2c_dev *dev) /* set standard and fast speed deviders for high/low periods */ + if

Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2013-10-09 Thread Ryan Mallon
On 09/10/13 18:55, Mika Westerberg wrote: > On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote: >> static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable) >> @@ -286,6 +287,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev) >> u32 input_clock_khz; >> u32 hcnt, lcnt; >>

Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2013-10-09 Thread Mika Westerberg
On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote: > static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable) > @@ -286,6 +287,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev) > u32 input_clock_khz; > u32 hcnt, lcnt; > u32 reg; > + u32 sda_falling_time, scl

[PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2013-10-08 Thread Romain Baeriswyl
This patch allows to set independantly SCL and SDA falling times. The tLOW period is computed by taking into account the SCL falling time. The tHIGH period is computed by taking into account the SDA falling time. For instance in case the margin on tLOW is considered too small, it can be increase