Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-27 Thread Andrew Morton
On Sun, 25 Nov 2007 11:21:48 +0800 "peerchen" <[EMAIL PROTECTED]> wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. So it should be set when enable the MSI. > > The patch base on kernel 2.6.24-rc3 > > Signed-off-by: Andy Currid <[EMAIL PROTECTED]> >

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-27 Thread Andrew Morton
On Sun, 25 Nov 2007 11:21:45 +0100 Prakash Punnoor <[EMAIL PROTECTED]> wrote: > Yay: Sounds good. > One thing I noticed in the patch: > + if (((bridge_dev = pci_find_slot(0, 0)) != NULL) && > > You rather want to use pci_get_bus_and_slot instead, as pci_find_slot is > deprecated.

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-27 Thread Andrew Morton
On Sun, 25 Nov 2007 11:21:45 +0100 Prakash Punnoor [EMAIL PROTECTED] wrote: Yay: Sounds good. One thing I noticed in the patch: + if (((bridge_dev = pci_find_slot(0, 0)) != NULL) You rather want to use pci_get_bus_and_slot instead, as pci_find_slot is deprecated. yup.

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-27 Thread Andrew Morton
On Sun, 25 Nov 2007 11:21:48 +0800 peerchen [EMAIL PROTECTED] wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-26 Thread Sébastien Dugué
On Sun, 25 Nov 2007 11:21:48 +0800 "peerchen" <[EMAIL PROTECTED]> wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. So it should be set when enable the MSI. > Cool, I had a patch that added a quirk to enable MSI Mapping on Broadcom's HT1000 so that

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-26 Thread Sébastien Dugué
On Sun, 25 Nov 2007 11:21:48 +0800 peerchen [EMAIL PROTECTED] wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. Cool, I had a patch that added a quirk to enable MSI Mapping on Broadcom's HT1000 so that the

RE: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Andy Currid
peerchen Cc: linux-kernel; akpm; Peer Chen; Andy Currid Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. > > The patc

RE: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Peer Chen
r Chen; Andy Currid Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen wrote: > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. > > The patch base on kernel 2.6.24-rc3 > >

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Robert Hancock
peerchen wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> Isn't there a way we can

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Prakash Punnoor
Hi, > According to the HyperTransport spec, 'En' indicate if the MSI Mapping is > active. So it should be set when enable the MSI. Great! This is what I needed to get MSI going on my MCP51 board. I added some ids, but I think there were not necessary, as I only got PCI: :00:00.0: enabled

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Prakash Punnoor
Hi, According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. Great! This is what I needed to get MSI going on my MCP51 board. I added some ids, but I think there were not necessary, as I only got PCI: :00:00.0: enabled HT

Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Robert Hancock
peerchen wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid [EMAIL PROTECTED] Signed-off-by: Peer Chen [EMAIL PROTECTED] Isn't there a way we can

RE: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Peer Chen
Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid [EMAIL

RE: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-25 Thread Andy Currid
; akpm; Peer Chen; Andy Currid Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform peerchen wrote: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3

[PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-24 Thread peerchen
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- ---

[PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT platform

2007-11-24 Thread peerchen
According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. So it should be set when enable the MSI. The patch base on kernel 2.6.24-rc3 Signed-off-by: Andy Currid [EMAIL PROTECTED] Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.24-rc3/drivers/pci/msi.c.orig