Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-24 Thread Masahiro Yamada
Hi Boris, 2017-05-18 16:09 GMT+09:00 Boris Brezillon : >> >> One question about this part. >> >> >>/* If chip->ecc.size is already set, respect it. */ >>if (chip->ecc.size && step_size != chip->ecc.size) >>continue; >> >> Does this make sense for nand_try_to_maximi

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-18 Thread Boris Brezillon
On Thu, 18 May 2017 15:27:11 +0900 Masahiro Yamada wrote: > Hi Boris, > > > > 2017-05-15 20:54 GMT+09:00 Boris Brezillon > : > > Hi Masahiro, > > > > Sorry for the late reply. > > > > On Mon, 8 May 2017 12:40:47 +0900 > > Masahiro Yamada wrote: > > > >> Hi Boris, > >> > >> > >> 2017-04-29

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-17 Thread Masahiro Yamada
Hi Boris, 2017-05-15 20:54 GMT+09:00 Boris Brezillon : > Hi Masahiro, > > Sorry for the late reply. > > On Mon, 8 May 2017 12:40:47 +0900 > Masahiro Yamada wrote: > >> Hi Boris, >> >> >> 2017-04-29 1:32 GMT+09:00 Boris Brezillon >> : >> >> >> + for (setting = caps->ecc_settings; setting->s

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-15 Thread Boris Brezillon
Hi Masahiro, Sorry for the late reply. On Mon, 8 May 2017 12:40:47 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2017-04-29 1:32 GMT+09:00 Boris Brezillon > : > > >> + for (setting = caps->ecc_settings; setting->step; setting++) { > >> + /* If chip->ecc.size is already set,

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-05-07 Thread Masahiro Yamada
Hi Boris, 2017-04-29 1:32 GMT+09:00 Boris Brezillon : >> + for (setting = caps->ecc_settings; setting->step; setting++) { >> + /* If chip->ecc.size is already set, respect it. */ >> + if (chip->ecc.size && setting->step != chip->ecc.size) >> + cont

Re: [PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-04-28 Thread Boris Brezillon
Hi Masahiro, Sorry for the delay, I was busy with non-NAND/MTD stuff lately. On Wed, 19 Apr 2017 16:06:57 +0900 Masahiro Yamada wrote: > Each driver has been responsible for: > - Check if ECC setting specified (mostly by DT) is valid > - Meet the chip's required ECC strength > - Maximize

[PATCH 1/2] mtd: nand: add generic helpers to check, match, maximize ECC settings

2017-04-19 Thread Masahiro Yamada
Each driver has been responsible for: - Check if ECC setting specified (mostly by DT) is valid - Meet the chip's required ECC strength - Maximize the strength when NAND_ECC_MAXIMIZE flag is set The logic can be generalized by factoring out driver-specific parameters. A driver provides: -