Re: [ckrm-tech] [PATCH 1/2] rcfs core patch

2007-03-13 Thread Herbert Poetzl
On Tue, Mar 13, 2007 at 07:41:37PM +0530, Srivatsa Vaddagiri wrote: > On Tue, Mar 13, 2007 at 02:55:05PM +0100, Herbert Poetzl wrote: > > yes, tons of locking, complicated indirections and > > a lot of (partially hard to understand) code ... > > Are you referring to these issues in the general Pau

Re: [ckrm-tech] [PATCH 1/2] rcfs core patch

2007-03-13 Thread Srivatsa Vaddagiri
On Tue, Mar 13, 2007 at 02:55:05PM +0100, Herbert Poetzl wrote: > yes, tons of locking, complicated indirections and > a lot of (partially hard to understand) code ... Are you referring to these issues in the general Paul Menage's container code or in the RSS-control code posted by Pavel? -- Reg

Re: [PATCH 1/2] rcfs core patch

2007-03-13 Thread Herbert Poetzl
On Tue, Mar 13, 2007 at 11:28:06AM +0300, Kirill Korotaev wrote: > >>>well, Linux-VServer is "working", "secure", "flexible" > >>>_and_ non-intrusive ... it is quite natural that less > >>>won't work for me ... and regarding patches, there > >>>will be a 2.2 release soon, with all the patches ...

Re: [PATCH 1/2] rcfs core patch

2007-03-13 Thread Kirill Korotaev
>>>well, Linux-VServer is "working", "secure", "flexible" >>>_and_ non-intrusive ... it is quite natural that less >>>won't work for me ... and regarding patches, there >>>will be a 2.2 release soon, with all the patches ... > > >>ok. please check your dcache and slab accounting then >>(analyzed

Re: [PATCH 1/2] rcfs core patch

2007-03-12 Thread Herbert Poetzl
On Sun, Mar 11, 2007 at 11:36:04AM -0500, Serge E. Hallyn wrote: > Quoting Herbert Poetzl ([EMAIL PROTECTED]): > > On Fri, Mar 09, 2007 at 11:27:07PM +0530, Srivatsa Vaddagiri wrote: > > > On Fri, Mar 09, 2007 at 01:38:19AM +0100, Herbert Poetzl wrote: > > > > > 2) you allow a task to selectively r

Re: [PATCH 1/2] rcfs core patch

2007-03-12 Thread Herbert Poetzl
On Sun, Mar 11, 2007 at 08:09:29PM +0300, Kirill Korotaev wrote: > Herbert, > > > sorry, I'm not in the lucky position that I get payed > > for sending patches to LKML, so I have to think twice > > before I invest time in coding up extra patches ... > > > > i.e. you will have to live with my comm

Re: [PATCH 1/2] rcfs core patch

2007-03-11 Thread Kirill Korotaev
Herbert, > sorry, I'm not in the lucky position that I get payed > for sending patches to LKML, so I have to think twice > before I invest time in coding up extra patches ... > > i.e. you will have to live with my comments for now looks like you have no better argurments then that... >>Looks lik

Re: [PATCH 1/2] rcfs core patch

2007-03-11 Thread Serge E. Hallyn
Quoting Herbert Poetzl ([EMAIL PROTECTED]): > On Fri, Mar 09, 2007 at 11:27:07PM +0530, Srivatsa Vaddagiri wrote: > > On Fri, Mar 09, 2007 at 01:38:19AM +0100, Herbert Poetzl wrote: > > > > 2) you allow a task to selectively reshare namespaces/subsystems with > > > >another task, i.e. you can u

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Paul Jackson
Herbert wrote: > personally, I'd prefer to avoid hierarchical > structures wherever possible, Sure - avoid them if you like. But sometimes they work out rather well. And file system API's are sometimes the best fit for them. I'm all for choosing the simplest API topology that makes sense. But

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Herbert Poetzl
On Fri, Mar 09, 2007 at 11:27:07PM +0530, Srivatsa Vaddagiri wrote: > On Fri, Mar 09, 2007 at 01:38:19AM +0100, Herbert Poetzl wrote: > > > 2) you allow a task to selectively reshare namespaces/subsystems with > > >another task, i.e. you can update current->task_proxy to point to > > >a pro

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Herbert Poetzl
On Fri, Mar 09, 2007 at 11:25:47AM -0800, Paul Jackson wrote: > > Ease of use maybe. Scripts can be more readily used with a fs-based > > interface. > > And, as I might have already stated, file system API's are a natural > fit for hierarchically shaped data, especially if the nodes in the > hiera

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Herbert Poetzl
On Fri, Mar 09, 2007 at 11:44:22PM +0530, Srivatsa Vaddagiri wrote: > On Fri, Mar 09, 2007 at 01:48:16AM +0100, Herbert Poetzl wrote: > > > There have been various projects attempting to provide resource > > > management support in Linux, including CKRM/Resource Groups and UBC. > > let me note her

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Paul Jackson
> Ease of use maybe. Scripts can be more readily used with a fs-based > interface. And, as I might have already stated, file system API's are a natural fit for hierarchically shaped data, especially if the nodes in the hierarchy would benefit from file system like permission attributes. --

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Srivatsa Vaddagiri
On Fri, Mar 09, 2007 at 01:48:16AM +0100, Herbert Poetzl wrote: > > There have been various projects attempting to provide resource > > management support in Linux, including CKRM/Resource Groups and UBC. > > let me note here, once again, that you forgot Linux-VServer > which does quite non-intrus

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Srivatsa Vaddagiri
On Fri, Mar 09, 2007 at 01:38:19AM +0100, Herbert Poetzl wrote: > > 2) you allow a task to selectively reshare namespaces/subsystems with > >another task, i.e. you can update current->task_proxy to point to > >a proxy that matches your existing task_proxy in some ways and the > >task_pr

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Serge E. Hallyn
Quoting Srivatsa Vaddagiri ([EMAIL PROTECTED]): > On Wed, Mar 07, 2007 at 08:12:00PM -0700, Eric W. Biederman wrote: > > I have a question? What does rcfs look like if we start with > > the code that is in the kernel? That is start with namespaces > > and nsproxy and just build a filesystem to di

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Herbert Poetzl
On Fri, Mar 09, 2007 at 12:07:27PM +0300, Kirill Korotaev wrote: >> nobody actually cares about a precise accounting and >> calculating shares or partitions of whatever resource, >> all that matters is that you have a way to prevent a >> potential hostile environment from sucking up all your >>

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Herbert Poetzl
On Fri, Mar 09, 2007 at 12:23:55PM +0300, Kirill Korotaev wrote: >>> There have been various projects attempting to provide >>> resource management support in Linux, including >>> CKRM/Resource Groups and UBC. >> >> let me note here, once again, that you forgot Linux-VServer >> which does quite n

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Paul Jackson
Kirill, responding to Herbert: > > do we need or even want that? IMHO the hierarchical > > concept CKRM was designed with, was also the reason > > for it being slow, unuseable and complicated > 1. cpusets are hierarchical already. So hierarchy is required. I think that CKRM has a harder time doing

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Kirill Korotaev
>>There have been various projects attempting to provide resource >>management support in Linux, including CKRM/Resource Groups and UBC. > > > let me note here, once again, that you forgot Linux-VServer > which does quite non-intrusive resource management ... Herbert, do you care to send patches

Re: [PATCH 1/2] rcfs core patch

2007-03-09 Thread Kirill Korotaev
> nobody actually cares about a precise accounting and > calculating shares or partitions of whatever resource, > all that matters is that you have a way to prevent a > potential hostile environment from sucking up all your > resources (or even a single one) resulting in a DoS This is not true

Re: [PATCH 1/2] rcfs core patch

2007-03-08 Thread Paul Jackson
Herbert wrote: > why is the filesystem approach so favored for this > kind of manipulations? I don't have any clear sense of whether the additional uses of file systems being considered here are a good idea or not, but the use of a file system for cpusets has turned out quite well, in my (vain and

Re: [PATCH 1/2] rcfs core patch

2007-03-08 Thread Herbert Poetzl
On Thu, Mar 08, 2007 at 03:43:47PM +0530, Srivatsa Vaddagiri wrote: > On Wed, Mar 07, 2007 at 08:12:00PM -0700, Eric W. Biederman wrote: > > The review is still largely happening at the why level but no > > one is addressing that yet. So please can we have a why. > > Here's a brief summary of wha

Re: [PATCH 1/2] rcfs core patch

2007-03-08 Thread Herbert Poetzl
On Thu, Mar 08, 2007 at 01:10:24AM -0800, Paul Menage wrote: > On 3/7/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > > > Please next time this kind of patch is posted add a description of > > what is happening and why. I have yet to see people explain why > > this is a good idea. Why the cu

Re: [PATCH 1/2] rcfs core patch

2007-03-08 Thread Srivatsa Vaddagiri
On Wed, Mar 07, 2007 at 08:12:00PM -0700, Eric W. Biederman wrote: > The review is still largely happening at the why level but no > one is addressing that yet. So please can we have a why. Here's a brief summary of what's happening and why. If its not clear, pls get back to us with specific que

Re: [PATCH 1/2] rcfs core patch

2007-03-08 Thread Paul Menage
On 3/7/07, Eric W. Biederman <[EMAIL PROTECTED]> wrote: Please next time this kind of patch is posted add a description of what is happening and why. I have yet to see people explain why this is a good idea. Why the current semantics were chosen. OK. I thought that the descriptions in my las

Re: [PATCH 1/2] rcfs core patch

2007-03-07 Thread Eric W. Biederman
Srivatsa Vaddagiri <[EMAIL PROTECTED]> writes: > Heavily based on Paul Menage's (inturn cpuset) work. The big difference > is that the patch uses task->nsproxy to group tasks for resource control > purpose (instead of task->containers). > > The patch retains the same user interface as Paul Menage'

Re: [ckrm-tech] [PATCH 1/2] rcfs core patch

2007-03-03 Thread Srivatsa Vaddagiri
On Fri, Mar 02, 2007 at 10:36:49AM +0530, Balbir Singh wrote: > With this don't we end up with a lot of duplicate between cpusets and rcfs. Unless we remove the duplication in cpusets and make it work with rcfs/containers! I wonder if we can avoid so much of filesystem code and use something like

Re: [ckrm-tech] [PATCH 1/2] rcfs core patch

2007-03-01 Thread Balbir Singh
Srivatsa Vaddagiri wrote: Heavily based on Paul Menage's (inturn cpuset) work. The big difference is that the patch uses task->nsproxy to group tasks for resource control purpose (instead of task->containers). The patch retains the same user interface as Paul Menage's patches. In particular, you

Re: [PATCH 1/2] rcfs core patch

2007-03-01 Thread Srivatsa Vaddagiri
On Thu, Mar 01, 2007 at 10:31:26AM -0600, Serge E. Hallyn wrote: > we've already had some trouble with nsproxy holding things with > different lifetimes. As it happens the solution this time was to put > the pid namespace where it belongs - not in nsproxy - so maybe moving > this info into nsproxi

Re: [PATCH 1/2] rcfs core patch

2007-03-01 Thread Serge E. Hallyn
Quoting Srivatsa Vaddagiri ([EMAIL PROTECTED]): > Heavily based on Paul Menage's (inturn cpuset) work. The big difference > is that the patch uses task->nsproxy to group tasks for resource control > purpose (instead of task->containers). Hi, we've already had some trouble with nsproxy holding thi

[PATCH 1/2] rcfs core patch

2007-03-01 Thread Srivatsa Vaddagiri
Heavily based on Paul Menage's (inturn cpuset) work. The big difference is that the patch uses task->nsproxy to group tasks for resource control purpose (instead of task->containers). The patch retains the same user interface as Paul Menage's patches. In particular, you can have multiple hierarchi