Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-20 Thread Stephen Warren
On 03/20/2013 04:19 PM, Stephen Warren wrote: > On 03/19/2013 10:50 AM, Mark Brown wrote: >> On Mon, Mar 18, 2013 at 05:41:49PM -0600, Stephen Warren wrote: >> >>> It took a very quick look at the patch and couldn't see anything >>> actively wrong. I wonder if one of the existing unconverted users

Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-20 Thread Stephen Warren
On 03/19/2013 10:50 AM, Mark Brown wrote: > On Mon, Mar 18, 2013 at 05:41:49PM -0600, Stephen Warren wrote: > >> It took a very quick look at the patch and couldn't see anything >> actively wrong. I wonder if one of the existing unconverted users >> of .parse_val() relies on the in-place modifica

Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-18 Thread Stephen Warren
On 03/03/2013 06:14 PM, Mark Brown wrote: > Currently the value parsing operations both return the parsed value and > modify the passed buffer. This precludes their use in places like the cache > code so split out the in place modification into a new parse_inplace() > operation. Mark, This change

[PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-03 Thread Mark Brown
Currently the value parsing operations both return the parsed value and modify the passed buffer. This precludes their use in places like the cache code so split out the in place modification into a new parse_inplace() operation. Signed-off-by: Mark Brown --- drivers/base/regmap/internal.h |