Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Krzysztof Kozlowski
On Thu, Apr 07, 2016 at 02:16:29PM -0400, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/07/2016 08:30 AM, Krzysztof Kozlowski wrote: > > On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: > >> The driver's init and exit function don't do anything besides

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Krzysztof Kozlowski
On Thu, Apr 07, 2016 at 02:16:29PM -0400, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/07/2016 08:30 AM, Krzysztof Kozlowski wrote: > > On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: > >> The driver's init and exit function don't do anything besides

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 04/07/2016 08:30 AM, Krzysztof Kozlowski wrote: > On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: >> The driver's init and exit function don't do anything besides registering >> and unregistering the platform driver, so the module_platform_driver() >>

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Javier Martinez Canillas
Hello Krzysztof, On 04/07/2016 08:30 AM, Krzysztof Kozlowski wrote: > On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: >> The driver's init and exit function don't do anything besides registering >> and unregistering the platform driver, so the module_platform_driver() >>

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Krzysztof Kozlowski
On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: > The driver's init and exit function don't do anything besides registering > and unregistering the platform driver, so the module_platform_driver() > macro could just be used instead of having separate functions. > >

Re: [PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-07 Thread Krzysztof Kozlowski
On Wed, Apr 06, 2016 at 09:49:46AM -0400, Javier Martinez Canillas wrote: > The driver's init and exit function don't do anything besides registering > and unregistering the platform driver, so the module_platform_driver() > macro could just be used instead of having separate functions. > >

[PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-06 Thread Javier Martinez Canillas
The driver's init and exit function don't do anything besides registering and unregistering the platform driver, so the module_platform_driver() macro could just be used instead of having separate functions. Currently the macro is not being used because the driver is initialized at subsys init

[PATCH 1/2] regulator: s2mps11: Use module_platform_driver() instead subsys initcall

2016-04-06 Thread Javier Martinez Canillas
The driver's init and exit function don't do anything besides registering and unregistering the platform driver, so the module_platform_driver() macro could just be used instead of having separate functions. Currently the macro is not being used because the driver is initialized at subsys init