Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-02 Thread atull
On Thu, 2 Oct 2014, Arnd Bergmann wrote: > On Thursday 02 October 2014 01:16:46 Pavel Machek wrote: > > > > > > > > struct socfpga_reset_manager { > > > > u32 status; > > > > u32 ctrl; > > > > u32 counts; > > > > u32 padding1; > > > > u32

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-02 Thread Arnd Bergmann
On Thursday 02 October 2014 01:16:46 Pavel Machek wrote: > > > > > > struct socfpga_reset_manager { > > > u32 status; > > > u32 ctrl; > > > u32 counts; > > > u32 padding1; > > > u32 mpu_mod_reset; > > > u32 per_mod_reset; > >

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-02 Thread Dinh Nguyen
On 10/1/14, 6:16 PM, Pavel Machek wrote: > On Wed 2014-10-01 11:07:18, Dinh Nguyen wrote: >> >> >> On 10/1/14, 10:04 AM, Pavel Machek wrote: >>> Hi! >>> >> +__raw_writel(RSTMGR_MPUMODRST_CPU1, >> + rst_manager_base_addr + 0x10); > > Woul

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-01 Thread Pavel Machek
On Wed 2014-10-01 11:07:18, Dinh Nguyen wrote: > > > On 10/1/14, 10:04 AM, Pavel Machek wrote: > > Hi! > > > +__raw_writel(RSTMGR_MPUMODRST_CPU1, > + rst_manager_base_addr + 0x10); > >>> > >>> Would it be possible to copy reset manager descri

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-01 Thread Dinh Nguyen
On 10/1/14, 10:04 AM, Pavel Machek wrote: > Hi! > + __raw_writel(RSTMGR_MPUMODRST_CPU1, + rst_manager_base_addr + 0x10); >>> >>> Would it be possible to copy reset manager description struct from >>> u-boot and use it here, instead of raw offset? >> >> I

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-01 Thread Pavel Machek
Hi! > > > + __raw_writel(RSTMGR_MPUMODRST_CPU1, > > > + rst_manager_base_addr + 0x10); > > > > Would it be possible to copy reset manager description struct from > > u-boot and use it here, instead of raw offset? > > I will replace this 0x10 with a macro that reflect

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-01 Thread atull
On Wed, 1 Oct 2014, Pavel Machek wrote: > Hi! > > > From: Alan Tull > > > > Use WFI when putting CPU1 to sleep. Don't hold CPU1 in reset > > since that results in increased power consumption. > > > > Reset CPU1 briefly during CPU1 bootup. > > > > This has been tested for hotplug and suspend/

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-10-01 Thread Pavel Machek
Hi! > From: Alan Tull > > Use WFI when putting CPU1 to sleep. Don't hold CPU1 in reset > since that results in increased power consumption. > > Reset CPU1 briefly during CPU1 bootup. > > This has been tested for hotplug and suspend/resume and results > in no increased power consumption. > >

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-09-25 Thread atull
On Wed, 24 Sep 2014, Russell King - ARM Linux wrote: Hi Russell, > On Wed, Sep 24, 2014 at 03:27:28PM -0500, at...@opensource.altera.com wrote: > > diff --git a/arch/arm/mach-socfpga/platsmp.c > > b/arch/arm/mach-socfpga/platsmp.c > > index 5356a72..1d5f8ad 100644 > > --- a/arch/arm/mach-socfpga

Re: [PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-09-24 Thread Russell King - ARM Linux
On Wed, Sep 24, 2014 at 03:27:28PM -0500, at...@opensource.altera.com wrote: > diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c > index 5356a72..1d5f8ad 100644 > --- a/arch/arm/mach-socfpga/platsmp.c > +++ b/arch/arm/mach-socfpga/platsmp.c > @@ -34,6 +34,10 @@ static i

[PATCH 1/2] socfpga: hotplug: put cpu1 in wfi

2014-09-24 Thread atull
From: Alan Tull Use WFI when putting CPU1 to sleep. Don't hold CPU1 in reset since that results in increased power consumption. Reset CPU1 briefly during CPU1 bootup. This has been tested for hotplug and suspend/resume and results in no increased power consumption. Signed-off-by: Alan Tull -