Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-03 Thread Stephen Warren
On 01/02/2013 08:25 PM, Tony Prisk wrote: > Move mach-vt8500/timer.c to drivers/clocksource/vt8500_timer.c > and make necessary changes to Kconfig and Makefile. > > vt8500_timer is moved from vt8500.c to clocksource/vt8500_timer.c > and added to common.h for reference from the board descriptor. >

Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-03 Thread Arnd Bergmann
On Thursday 03 January 2013, Joe Perches wrote: > Also I think it'd be nicer to write something like: > > struct device_node *np; > int timer_irq; > const char *reason; > > np = of_find_matching_node(NULL, vt8500_timer_ids); > if (!np) { > r

Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Joe Perches
On Wed, 2013-01-02 at 23:35 -0800, Dmitry Torokhov wrote: > On Thu, Jan 03, 2013 at 04:25:09PM +1300, Tony Prisk wrote: > > +static void __init vt8500_timer_init(void) > > +{ > > + struct device_node *np; > > + int timer_irq; > > + > > + np = of_find_matching_node(NULL, vt8500_timer_ids); > >

Re: [PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Dmitry Torokhov
On Thu, Jan 03, 2013 at 04:25:09PM +1300, Tony Prisk wrote: > +static void __init vt8500_timer_init(void) > +{ > + struct device_node *np; > + int timer_irq; > + > + np = of_find_matching_node(NULL, vt8500_timer_ids); > + if (!np) { > + pr_err("%s: Timer description miss

[PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Tony Prisk
Move mach-vt8500/timer.c to drivers/clocksource/vt8500_timer.c and make necessary changes to Kconfig and Makefile. vt8500_timer is moved from vt8500.c to clocksource/vt8500_timer.c and added to common.h for reference from the board descriptor. Signed-off-by: Tony Prisk --- CC: John Stultz CC: T