Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-29 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 29.10.13 at 10:54, Ingo Molnar wrote: > > > * Jan Beulich wrote: > > > >> >>> On 26.10.13 at 12:31, Ingo Molnar wrote: > >> > * Jan Beulich wrote: > >> >> I'd like to point out though that with __compiletime_object_size() > >> >> being restricted to gcc before

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-29 Thread Jan Beulich
>>> On 29.10.13 at 10:54, Ingo Molnar wrote: > * Jan Beulich wrote: > >> >>> On 26.10.13 at 12:31, Ingo Molnar wrote: >> > * Jan Beulich wrote: >> >> I'd like to point out though that with __compiletime_object_size() >> >> being restricted to gcc before 4.6, the whole construct is going to >>

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-29 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 26.10.13 at 12:31, Ingo Molnar wrote: > > * Jan Beulich wrote: > >> I'd like to point out though that with __compiletime_object_size() > >> being restricted to gcc before 4.6, the whole construct is going to > >> become more and more pointless going forward. I wou

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-29 Thread Jan Beulich
>>> On 26.10.13 at 12:31, Ingo Molnar wrote: > * Jan Beulich wrote: >> I'd like to point out though that with __compiletime_object_size() >> being restricted to gcc before 4.6, the whole construct is going to >> become more and more pointless going forward. I would question >> however that commit

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-28 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 26.10.13 at 12:31, Ingo Molnar wrote: > > * Jan Beulich wrote: > >> I'd like to point out though that with __compiletime_object_size() > >> being restricted to gcc before 4.6, the whole construct is going to > >> become more and more pointless going forward. I wou

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-28 Thread Jan Beulich
>>> On 26.10.13 at 12:31, Ingo Molnar wrote: > * Jan Beulich wrote: >> I'd like to point out though that with __compiletime_object_size() >> being restricted to gcc before 4.6, the whole construct is going to >> become more and more pointless going forward. I would question >> however that commit

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-26 Thread Guenter Roeck
On 10/26/2013 03:31 AM, Ingo Molnar wrote: * Jan Beulich wrote: Commits 4a3127693001c61a21d1ce680db6340623f52e93 ("x86: Turn the copy_from_user check into an (optional) compile time warning") and 63312b6a6faae3f2e5577f2b001e3b504f10a2aa ("x86: Add a Kconfig option to turn the copy_from_user w

Re: [PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-26 Thread Ingo Molnar
* Jan Beulich wrote: > Commits 4a3127693001c61a21d1ce680db6340623f52e93 ("x86: Turn the > copy_from_user check into an (optional) compile time warning") and > 63312b6a6faae3f2e5577f2b001e3b504f10a2aa ("x86: Add a Kconfig option to > turn the copy_from_user warnings into errors") touched only the

[PATCH 1/2] x86: unify copy_from_user() size checking

2013-10-21 Thread Jan Beulich
Commits 4a3127693001c61a21d1ce680db6340623f52e93 ("x86: Turn the copy_from_user check into an (optional) compile time warning") and 63312b6a6faae3f2e5577f2b001e3b504f10a2aa ("x86: Add a Kconfig option to turn the copy_from_user warnings into errors") touched only the 32-bit variant of copy_from_use