Re: [PATCH 1/3] cifs: Remove unused cEVENT macro

2012-12-04 Thread Joe Perches
(resending due to bounces, sorry for any inconvenience) On Fri, 2012-11-30 at 09:39 -0600, Steve French wrote: > But ... the need still remains for more tracing for cifs (I run into > this a few times a month at least when debugging) - does anyone have > any ideas for how to add dynamic trace poin

Re: [PATCH 1/3] cifs: Remove unused cEVENT macro

2012-12-03 Thread Joe Perches
On Fri, 2012-11-30 at 09:39 -0600, Steve French wrote: > But ... the need still remains for more tracing for cifs (I run into > this a few times a month at least when debugging) - does anyone have > any ideas for how to add dynamic trace points to cifs (has anyone even > done it for the vfs?) - is

Re: [PATCH 1/3] cifs: Remove unused cEVENT macro

2012-11-30 Thread Steve French
I don't mind removing cEVENT (it is currently unused, and presumably the older file systems that used EVENT logging, have moved to dtrace or other tracing mechanisms). But ... the need still remains for more tracing for cifs (I run into this a few times a month at least when debugging) - does anyo

Re: [PATCH 1/3] cifs: Remove unused cEVENT macro

2012-11-30 Thread Jeff Layton
On Thu, 29 Nov 2012 11:37:18 -0800 Joe Perches wrote: > It uses an undefined KERN_EVENT and is itself unused. > > Signed-off-by: Joe Perches > --- > fs/cifs/cifs_debug.h |7 --- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_deb

[PATCH 1/3] cifs: Remove unused cEVENT macro

2012-11-29 Thread Joe Perches
It uses an undefined KERN_EVENT and is itself unused. Signed-off-by: Joe Perches --- fs/cifs/cifs_debug.h |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h index c0c68bb..b0fc344 100644 --- a/fs/cifs/cifs_debug.h +++ b/fs/c