Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Thomas Petazzoni
Hello, On Wed, 8 Mar 2017 17:24:21 +0100, Gregory CLEMENT wrote: > Signed-off-by: jinghua I think you need a full first name + last name for this Signed-off-by. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Thomas Petazzoni
Hello, On Wed, 8 Mar 2017 17:24:21 +0100, Gregory CLEMENT wrote: > Signed-off-by: jinghua I think you need a full first name + last name for this Signed-off-by. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
Hi Andrew, On mer., mars 08 2017, Andrew Lunn wrote: > Hi Gregory [...] Thanks for your comments I will fix the typos and the wording. >> +#define USB_SBUSCFG 0x90 >> +#define USB_SBUSCFG_BAWR0x6 >> +#define USB_SBUSCFG_BARD0x3 >>

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
Hi Andrew, On mer., mars 08 2017, Andrew Lunn wrote: > Hi Gregory [...] Thanks for your comments I will fix the typos and the wording. >> +#define USB_SBUSCFG 0x90 >> +#define USB_SBUSCFG_BAWR0x6 >> +#define USB_SBUSCFG_BARD0x3 >> +#define

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Andrew Lunn
Hi Gregory > - Add a new compatoble string for the Armada 3700 SoCs compatible > > - add sbuscfg support for orion usb controller driver. For the SoCs > without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg > register to guarantee the AHB master's burst would not overrun

Re: [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Andrew Lunn
Hi Gregory > - Add a new compatoble string for the Armada 3700 SoCs compatible > > - add sbuscfg support for orion usb controller driver. For the SoCs > without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg > register to guarantee the AHB master's burst would not overrun

[PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
From: jinghua - Add a new compatoble string for the Armada 3700 SoCs - add sbuscfg support for orion usb controller driver. For the SoCs without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg register to guarantee the AHB master's burst would not overrun

[PATCH 1/3] usb: orion-echi: Add support for the Armada 3700

2017-03-08 Thread Gregory CLEMENT
From: jinghua - Add a new compatoble string for the Armada 3700 SoCs - add sbuscfg support for orion usb controller driver. For the SoCs without hlock, need to program BAWR/BARD/AHBBRST fields in the sbuscfg register to guarantee the AHB master's burst would not overrun or underrun the