Re: [PATCH 1/3] x86: Bugfix bit-rot in the calling of legacy_cache_size

2014-09-30 Thread Bryan O'Donoghue
On 30/09/14 21:28, Thomas Gleixner wrote: On Tue, 30 Sep 2014, Bryan O'Donoghue wrote: static void default_init(struct cpuinfo_x86 *c) { -#ifdef CONFIG_X86_64 cpu_detect_cache_sizes(c); -#else + /* Not much we can do here... */ /* Check if at least it has cpuid */

Re: [PATCH 1/3] x86: Bugfix bit-rot in the calling of legacy_cache_size

2014-09-30 Thread Thomas Gleixner
On Tue, 30 Sep 2014, Bryan O'Donoghue wrote: > static void default_init(struct cpuinfo_x86 *c) > { > -#ifdef CONFIG_X86_64 > cpu_detect_cache_sizes(c); > -#else > + > /* Not much we can do here... */ > /* Check if at least it has cpuid */ > if (c->cpuid_level == -1) { > @@

Re: [PATCH 1/3] x86: Bugfix bit-rot in the calling of legacy_cache_size

2014-09-30 Thread Bryan O'Donoghue
On 30/09/14 04:41, Dave Jones wrote: Shouldn't this patch be more like.. -#ifdef CONFIG_X86_64 cpu_detect_cache_sizes(c); -#else + +#ifdef CONFIG_X86_32 ? Hmm, maybe but you have code in cpu_detect_cache_sizes that's X86_64 only.. void cpu_detect_cache_sizes(struct cpuinfo_x86 *c)

Re: [PATCH 1/3] x86: Bugfix bit-rot in the calling of legacy_cache_size

2014-09-29 Thread Dave Jones
On Tue, Sep 30, 2014 at 04:11:48AM +0100, Bryan O'Donoghue wrote: > Make an update to identify_cpu to make an explicit call to default_init() > We want to do this since some processors that report vendor strings via > cpuid also want to run legacy_cache_size callbacks - which won't happen > si

[PATCH 1/3] x86: Bugfix bit-rot in the calling of legacy_cache_size

2014-09-29 Thread Bryan O'Donoghue
legacy_cache_size is used by certain processors to report the size of cache. Currently only X86_VENDOR_UNKNOWN could call default_init() => cpu_detect_cache_sizes() => legacy_cache_size() Make an update to identify_cpu to make an explicit call to default_init() We want to do this since some proces