Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Felipe Balbi
On Tue, Sep 17, 2013 at 05:53:31PM +0200, Tomasz Figa wrote: > Hi Felipe, > > On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote: > > Hi, > > > > On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: > > > *Ping!* > > > > > > Are there still unanswered concerns left with this p

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Tomasz Figa
Hi Felipe, On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote: > Hi, > > On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: > > *Ping!* > > > > Are there still unanswered concerns left with this patch? I hope my > > prior mails could clear up why I think that the PMU registe

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Felipe Balbi
Hi, On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: > *Ping!* > > Are there still unanswered concerns left with this patch? I hope my > prior mails could clear up why I think that the PMU register > description in the device tree for a specific PHY is represents the > hardware more

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-27 Thread Julius Werner
*Ping!* Are there still unanswered concerns left with this patch? I hope my prior mails could clear up why I think that the PMU register description in the device tree for a specific PHY is represents the hardware more accurately after my patch, and my analysis of the Exynos4 situation currently n

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Julius Werner
> Sorry, I don't understand what is not implemented. Without your patch, the > PHY driver handles both PMU registers of Exynos4. I don't have an Exynos4 to actually test this, so please let me know if I'm missing something here... but in order to hit the right HOST PHY register in the current upst

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Tomasz Figa
Hi Julius, On Thursday 08 of August 2013 11:06:54 Julius Werner wrote: > > I'm not sure I understand. The old documentation referred to the > > USBDEVICE_PHY_CONTROL and USBHOST_PHY_CONTROL registers for a phy, and > > your new version only refers to (usb device) PHY_CONTROL. Regardless > > of > >

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Julius Werner
> I'm not sure I understand. The old documentation referred to the > USBDEVICE_PHY_CONTROL and USBHOST_PHY_CONTROL registers for a phy, and > your new version only refers to (usb device) PHY_CONTROL. Regardless of > multiple phys, you're suggesting that we describe less of each phy. > That seems li

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Vivek Gautam
On Thu, Aug 8, 2013 at 2:56 PM, Mark Rutland wrote: > On Wed, Aug 07, 2013 at 06:06:05PM +0100, Julius Werner wrote: >> > This breaks compatibility, both for an old kernel and a new dt and a new >> > kernel with an old dt. Is anyone using these bindings? >> >> They only affect Samsung SoCs and hav

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-08 Thread Mark Rutland
On Wed, Aug 07, 2013 at 06:06:05PM +0100, Julius Werner wrote: > > This breaks compatibility, both for an old kernel and a new dt and a new > > kernel with an old dt. Is anyone using these bindings? > > They only affect Samsung SoCs and have only been upstream for half a > year, so I doubt it's he

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-07 Thread Sylwester Nawrocki
On 08/07/2013 07:06 PM, Julius Werner wrote: >> This breaks compatibility, both for an old kernel and a new dt and a new >> kernel with an old dt. Is anyone using these bindings? > > They only affect Samsung SoCs and have only been upstream for half a > year, so I doubt it's heavily used. It prob

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-07 Thread Julius Werner
> This breaks compatibility, both for an old kernel and a new dt and a new > kernel with an old dt. Is anyone using these bindings? They only affect Samsung SoCs and have only been upstream for half a year, so I doubt it's heavily used. > Why are we describing fewer registers now? Are they descri

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-07 Thread Mark Rutland
On Tue, Aug 06, 2013 at 07:00:17PM +0100, Julius Werner wrote: > This patch simplifies the way the phy-samsung-usb code finds the correct > power management register to enable PHY clock gating. Previously, the > code would calculate the register address from a device tree supplied > base address an

[PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-06 Thread Julius Werner
This patch simplifies the way the phy-samsung-usb code finds the correct power management register to enable PHY clock gating. Previously, the code would calculate the register address from a device tree supplied base address and add an offset based on the PHY type. Since every PHY has its own dev