Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

2015-11-16 Thread Vitaly Kuznetsov
Dan Carpenter writes: > On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: >> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const >> char __user *buf, >> return PTR_ERR(inmsg); >> >> if (hvt->on_msg(inmsg, count)) >> -return -EF

Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

2015-11-16 Thread Dan Carpenter
On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: > @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char > __user *buf, > return PTR_ERR(inmsg); > > if (hvt->on_msg(inmsg, count)) > - return -EFAULT; > + ret = -

[PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

2015-11-12 Thread Vitaly Kuznetsov
inmsg should be freed in case of on_msg() failure to avoid memory leak. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv_utils_transport.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c index 24b2766..1d