On Wed, Jan 9, 2013 at 4:04 PM, Russell King - ARM Linux
wrote:
> So, it seems there's some concensus building here, and it seems that
> I've become the chosen victi^wvolunteer for this. So, here's a patch.
> It's missing a Guns-supplied-by: tag though.
>
> From: Russell King
> Subject: Mark
On Wed, Jan 9, 2013 at 4:04 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
So, it seems there's some concensus building here, and it seems that
I've become the chosen victi^wvolunteer for this. So, here's a patch.
It's missing a Guns-supplied-by: tag though.
From: Russell King
On Wed, Jan 09, 2013 at 11:10:55AM +, Russell King - ARM Linux wrote:
[...]
> err = gpio_request(en_vdd_1v05, "EN_VDD_1V05");
> if (err) {
> pr_err("%s: gpio_request failed: %d\n", __func__, err);
> return err;
> }
>
>
On Wed, Jan 09, 2013 at 11:10:55AM +, Russell King - ARM Linux wrote:
[...]
err = gpio_request(en_vdd_1v05, EN_VDD_1V05);
if (err) {
pr_err(%s: gpio_request failed: %d\n, __func__, err);
return err;
}
* Russell King - ARM Linux [130109 09:15]:
> On Wed, Jan 09, 2013 at 04:21:45PM +, Russell King - ARM Linux wrote:
> > On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
> > > On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
> > >
> > > > On Wed, Jan 09, 2013 at 10:27:53AM
On Wed, Jan 09, 2013 at 04:21:45PM +, Russell King - ARM Linux wrote:
> On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
> > On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
> >
> > > On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
> > > > Anyone with good
On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
> On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
>
> > On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
> > > Anyone with good coccinelle skills around to deal with the users?
> >
> > I'm not sure that's a
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
> On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
> > Anyone with good coccinelle skills around to deal with the users?
>
> I'm not sure that's a solution.
Well, I was thinking that coccinelle could handle the majority of the
On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
> Anyone with good coccinelle skills around to deal with the users?
I'm not sure that's a solution.
For example:
err = gpio_request(en_vdd_1v05, "EN_VDD_1V05");
if (err) {
pr_err("%s: gpio_request
On Wed, Jan 9, 2013 at 3:04 PM, Russell King - ARM Linux
wrote:
> So, it seems there's some concensus building here, and it seems that
> I've become the chosen victi^wvolunteer for this. So, here's a patch.
> It's missing a Guns-supplied-by: tag though.
>
> From: Russell King
> Subject: Mark
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
> So, it seems there's some concensus building here, and it seems that
> I've become the chosen victi^wvolunteer for this. So, here's a patch.
> It's missing a Guns-supplied-by: tag though.
Guns-supplied-by: NRA (obviously)
> From: Russell
On Wednesday 09 January 2013, Grant Likely wrote:
> > Suggested-by: David Howells
> > Tape-measuring-service-offered-by: Will Deacon
> > Victim-for-firing-sqad: Russell King
> > Signed-off-by: Russell King
>
> Acked-by: Grant Likely
Acked-by: Arnd Bergmann
--
To unsubscribe from this list:
So, it seems there's some concensus building here, and it seems that
I've become the chosen victi^wvolunteer for this. So, here's a patch.
It's missing a Guns-supplied-by: tag though.
From: Russell King
Subject: Mark IS_ERR_OR_NULL() deprecated
IS_ERR_OR_NULL() attracts a lot of abuse: people
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
> On Wed, Jan 09, 2013 at 10:44:14AM +, Russell King - ARM Linux wrote:
> > On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
> > > On Wednesday 09 January 2013, Alexandre Courbot wrote:
> > > > On Tue, Jan 8, 2013 at 9:59 PM,
On Wednesday 09 January 2013, Russell King - ARM Linux wrote:
> d = debugfs_create_dir("pm_debug", NULL);
> if (IS_ERR_OR_NULL(d))
> return PTR_ERR(d);
>
> Well, covered above. NULL is success here.
This one is actually worse, because in case of
On Wed, Jan 09, 2013 at 10:44:14AM +, Russell King - ARM Linux wrote:
> On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
> > On Wednesday 09 January 2013, Alexandre Courbot wrote:
> > > On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann wrote:
> > > > Please avoid the use of
On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
> On Wednesday 09 January 2013, Alexandre Courbot wrote:
> > On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann wrote:
> > > Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
> > > introduce yourself. AFAICT, gpiod_get
On Wednesday 09 January 2013, Alexandre Courbot wrote:
> On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann wrote:
> > Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
> > introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
> > should not check for that.
>
> Sure -
On Wed, Jan 09, 2013 at 10:06:16AM +0900, Alexandre Courbot wrote:
> On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann wrote:
> > Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
> > introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
> > should not check for that.
On Wed, Jan 09, 2013 at 10:06:16AM +0900, Alexandre Courbot wrote:
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann a...@arndb.de wrote:
Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
should not check for
On Wednesday 09 January 2013, Alexandre Courbot wrote:
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann a...@arndb.de wrote:
Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
should not check for that.
On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
On Wednesday 09 January 2013, Alexandre Courbot wrote:
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann a...@arndb.de wrote:
Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
introduce yourself. AFAICT,
On Wed, Jan 09, 2013 at 10:44:14AM +, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
On Wednesday 09 January 2013, Alexandre Courbot wrote:
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann a...@arndb.de wrote:
Please avoid the use of
On Wednesday 09 January 2013, Russell King - ARM Linux wrote:
d = debugfs_create_dir(pm_debug, NULL);
if (IS_ERR_OR_NULL(d))
return PTR_ERR(d);
Well, covered above. NULL is success here.
This one is actually worse, because in case of debugfs_create_dir,
a
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:44:14AM +, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:35:22AM +, Arnd Bergmann wrote:
On Wednesday 09 January 2013, Alexandre Courbot wrote:
On Tue, Jan 8, 2013 at 9:59 PM, Arnd
So, it seems there's some concensus building here, and it seems that
I've become the chosen victi^wvolunteer for this. So, here's a patch.
It's missing a Guns-supplied-by: tag though.
From: Russell King rmk+ker...@arm.linux.org.uk
Subject: Mark IS_ERR_OR_NULL() deprecated
IS_ERR_OR_NULL()
On Wednesday 09 January 2013, Grant Likely wrote:
Suggested-by: David Howells dhowe...@redhat.com
Tape-measuring-service-offered-by: Will Deacon will.dea...@arm.com
Victim-for-firing-sqad: Russell King rmk+ker...@arm.linux.org.uk
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
So, it seems there's some concensus building here, and it seems that
I've become the chosen victi^wvolunteer for this. So, here's a patch.
It's missing a Guns-supplied-by: tag though.
Guns-supplied-by: NRA (obviously)
From: Russell King
On Wed, Jan 9, 2013 at 3:04 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
So, it seems there's some concensus building here, and it seems that
I've become the chosen victi^wvolunteer for this. So, here's a patch.
It's missing a Guns-supplied-by: tag though.
From: Russell King
On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
Anyone with good coccinelle skills around to deal with the users?
I'm not sure that's a solution.
For example:
err = gpio_request(en_vdd_1v05, EN_VDD_1V05);
if (err) {
pr_err(%s: gpio_request failed:
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
Anyone with good coccinelle skills around to deal with the users?
I'm not sure that's a solution.
Well, I was thinking that coccinelle could handle the majority of the
354
On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
Anyone with good coccinelle skills around to deal with the users?
I'm not sure that's a solution.
Well,
On Wed, Jan 09, 2013 at 04:21:45PM +, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 10:27:53AM -0500, Nicolas Pitre wrote:
Anyone with good coccinelle
* Russell King - ARM Linux li...@arm.linux.org.uk [130109 09:15]:
On Wed, Jan 09, 2013 at 04:21:45PM +, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at 11:09:23AM -0500, Nicolas Pitre wrote:
On Wed, 9 Jan 2013, Russell King - ARM Linux wrote:
On Wed, Jan 09, 2013 at
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann wrote:
> Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
> introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
> should not check for that.
Sure - you sound like IS_ERR_OR_NULL() is generally considered evil,
may I
On Tuesday 08 January 2013, Alexandre Courbot wrote:
> +struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
> +const char *con_id)
> +{
> + struct gpio_desc **dr;
> + struct gpio_desc *desc;
> +
> + dr =
On Tuesday 08 January 2013, Alexandre Courbot wrote:
+struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
+const char *con_id)
+{
+ struct gpio_desc **dr;
+ struct gpio_desc *desc;
+
+ dr =
On Tue, Jan 8, 2013 at 9:59 PM, Arnd Bergmann a...@arndb.de wrote:
Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
should not check for that.
Sure - you sound like IS_ERR_OR_NULL() is generally considered
With the current API, GPIOs are represented by a unique integer. This
causes problems in terms of security (GPIO numbers can be arbitrarily
forged and used without proper allocation) and flexibility (the maximum
number of GPIOs that the system can handle is fixed at compilation time
and a static
With the current API, GPIOs are represented by a unique integer. This
causes problems in terms of security (GPIO numbers can be arbitrarily
forged and used without proper allocation) and flexibility (the maximum
number of GPIOs that the system can handle is fixed at compilation time
and a static
40 matches
Mail list logo
